From 71d0152b8d8f349bb3deaebc19c5f898c3b7706b Mon Sep 17 00:00:00 2001 From: banisadr Date: Tue, 2 Jan 2024 13:36:09 -0800 Subject: [PATCH] Updating distortion model description to provide more details on implementation and use --- internal/schemas.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/schemas.ts b/internal/schemas.ts index 8e9c16e..074b5cf 100644 --- a/internal/schemas.ts +++ b/internal/schemas.ts @@ -693,7 +693,7 @@ const CameraCalibration: FoxgloveMessageSchema = { name: "distortion_model", type: { type: "primitive", name: "string" }, description: - "Name of distortion model\n\nSupported values: `plumb_bob` and `rational_polynomial`", + "Name of distortion model\n\nFoxglvoe supports `plumb_bob` (k1, k2, p1, p2, k3) and `rational_polynomial`(k1, k2, p1, p2, k3, k4, k5, k6) distortion based on [OpenCV's implementation](https://docs.opencv.org/2.4/modules/calib3d/doc/camera_calibration_and_3d_reconstruction.html) of the [Brown-Conrady pinhole camera model](https://en.wikipedia.org/wiki/Distortion_%28optics%29#Software_correction). This is the same [implementation used in ROS](http://docs.ros.org/en/diamondback/api/image_geometry/html/c++/pinhole__camera__model_8cpp_source.html)", }, { name: "D",