Introduce serve.WithFS() option #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaogris
force-pushed
the
fs
branch
3 times, most recently
from
ad74c8a
to
f344490
Compare
Introduce serve.WithFS() option so that we can use serve with embed.FS. In order to make test embed.FS we cannot use links and we need to place the .pb file in the same directory as the methods. This is a temporary state until we cleanup NewServer in a more comprehensive, not allowing for .pb files to be specified separately from the method dirs.
camh-
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce serve.WithFS() option so that we can use serve with embed.FS.
In order to make test embed.FS we cannot use links and we need to place
the .pb file in the same directory as the methods.
This is a temporary state until we cleanup NewServer in a more
comprehensive, not allowing for .pb files to be specified separately
from the method dirs.