Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename white pattern / black pattern to e.g. pattern / bypass pattern #81

Open
murb opened this issue Jun 17, 2020 · 7 comments
Open

Rename white pattern / black pattern to e.g. pattern / bypass pattern #81

murb opened this issue Jun 17, 2020 · 7 comments

Comments

@murb
Copy link

@murb murb commented Jun 17, 2020

Please consider renaming black patterns and white patterns to something more inclusive and clearer. Besides that associating black with not passing and white with passing, is kind of offensive, I'd also think that the function of the two lists can be more clearly communicated when being renamed to e.g.

Proxy patterns and By pass patterns

Other projects have undergone similar changes. While a typical replacement seems to be blocklist / allowlist 'bypass' might be more suitable in the context of a proxy service(?) I'm not a native English speaker, maybe there is even a better term?

@ericjung
Copy link
Collaborator

@ericjung ericjung commented Jun 19, 2020

Happy Juneteenth. Please read response here.

TL;DR pull requests encouraged if you want this done faster. We will likely use green and red patterns to replace white and black in keeping with the colors analogy.

@murb
Copy link
Author

@murb murb commented Jun 21, 2020

Thanks for your response, good blog post! While red and green seem fine to me, dropping color-coding altogether as it still adds another level of abstraction; you still have to explain it... "green patterns" are patterns that will be fed into the proxy, whereas "red patterns" will bypass the proxy... why not state "proxy patterns" and "bypass patterns" (or "exception patterns")?

@dmrzzz
Copy link

@dmrzzz dmrzzz commented Jun 26, 2020

  1. Thanks for taking this seriously!
  2. From a user experience perspective, every single one of @murb's functional naming suggestions above is much clearer than green/red. Two more possible options (just in case they happen to resonate more): "match patterns" and "exclude patterns".
  3. The blog post claims that FoxyProxy does not use "whitelist", but that's not accurate; the phrase "Add whitelist pattern to match all URLs" appears in at least two places in the UI (the screenshot shown in the blog entry, and also when configuring a new proxy)
  4. Thanks for FoxyProxy in general, it's a fantastic add-on.

@xurizaemon
Copy link

@xurizaemon xurizaemon commented Jul 5, 2020

Agree with @murb analysis above that reducing abstraction is clearer.

"proxy" / "bypass" (or perhaps "proxy" / "direct"? per proxy.pac usage) seem clearer than "red" / "green", considering the common "red means stop" understanding, rather than bypass/direct.

In a UI that presents regex functionality, I don't think we need to abstract around concepts like proxy/direct with colours :)

As above, thanks for FoxyProxy!

@eean
Copy link

@eean eean commented Jul 29, 2020

folks are ignoring that you can have more than one proxy so really all patterns are proxy patterns. I see why folks are bouncing off of red/green since stoplights don't filter, so it's an imperfect analogy. But it seems like a fine analogy to use.

though an actual filter analogy might be better, like catch patterns and release patterns (analogy to fishing) ?

@erosman
Copy link
Collaborator

@erosman erosman commented Jul 29, 2020

What about a simple Include/Exclude?!

@ericjung
Copy link
Collaborator

@ericjung ericjung commented Jul 31, 2020

yes, include/exclude seems the simplest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants