add Function as Monoid #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinogermany
approved these changes
May 23, 2020
There was a problem hiding this comment.
Great stuff! I've left some minor comments but looks awesome overall. Thanks for this PR @stevemao
Comment on lines
+164
to
+165
| f x = f1 x <> mempty | ||
| f = f1 <> mempty |
There was a problem hiding this comment.
Not sure if it's useful for composition :).
But it is indeed a good brain exercise.
There was a problem hiding this comment.
@shineli1984 Yeah I wonder if there's any real life examples/usage of using this one?
shineli1984
reviewed
May 23, 2020
|
|
||
| -- | @since 2.01 | ||
| instance Monoid b => Monoid (a -> b) where | ||
| mempty _ = mempty |
There was a problem hiding this comment.
I’m wondering if it’s better to write mempty = const mempty
There was a problem hiding this comment.
This is just copy paste, same as other code under GHC Source Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.