From 9ebeb47dd4112842059aacf952b868ff68aba88d Mon Sep 17 00:00:00 2001 From: Michael Snoyman Date: Tue, 26 Aug 2025 11:35:59 +0300 Subject: [PATCH 1/2] Update toolchain to 1.89.0 --- .github/workflows/test.yaml | 2 +- rust-toolchain.toml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index a03e493..4c3daca 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -26,7 +26,7 @@ jobs: tool: just@1.25.2,nextest@0.9.82 - uses: dtolnay/rust-toolchain@master with: - toolchain: 1.81.0 + toolchain: 1.89.0 components: rustfmt, clippy - name: Compile run: just cargo-compile diff --git a/rust-toolchain.toml b/rust-toolchain.toml index 1de01fa..b67e7d5 100644 --- a/rust-toolchain.toml +++ b/rust-toolchain.toml @@ -1,2 +1,2 @@ [toolchain] -channel = "1.81.0" +channel = "1.89.0" From 36a8afffbf50ab8bed3f3b2cda7199f1537dbc73 Mon Sep 17 00:00:00 2001 From: Michael Snoyman Date: Tue, 26 Aug 2025 11:25:00 +0300 Subject: [PATCH 2/2] Report errors on stale cache --- src/lib.rs | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/lib.rs b/src/lib.rs index 52d7bf2..28d90f6 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -419,11 +419,15 @@ impl AsyncLoader { ValueForRender::Success { .. } => result, ValueForRender::Error { stale_cache: Some(stale_cache), - .. - } => ValueForRender::Success { - value: stale_cache.value, - loaded: stale_cache.loaded, - }, + message, + status, + } => { + tracing::error!("AsyncLoader::get_value_allow_stale: using stale cache, status=={status}, message: {message}"); + ValueForRender::Success { + value: stale_cache.value, + loaded: stale_cache.loaded, + } + } ValueForRender::Error { .. } => result, } }