New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually Fix GovCloud STS #8

Merged
merged 1 commit into from Sep 20, 2018

Conversation

Projects
None yet
2 participants
@dfinlay
Contributor

dfinlay commented Sep 19, 2018

Add region parameter to GovCloud STS calls. This makes assume roles actually work when assuming role, it was in #7 because I had my default region set to us-gov-west-1.

@borsboom

Aside from my minor formatting nitpick, looks good.

Show outdated Hide outdated aws/aws-env.sh Outdated
@dfinlay

This comment has been minimized.

Show comment
Hide comment
@dfinlay

dfinlay Sep 20, 2018

Contributor

The issue with the removed EOL spaces is fixed. Sorry about that, I have my editor configured to do that and should have caught it.

Contributor

dfinlay commented Sep 20, 2018

The issue with the removed EOL spaces is fixed. Sorry about that, I have my editor configured to do that and should have caught it.

@borsboom borsboom merged commit c2cf38b into fpco:master Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment