Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalise types of run*Server which never cleanly return #13

Merged
merged 1 commit into from Dec 17, 2014

Conversation

@DaveCTurner
Copy link
Contributor

commented Dec 11, 2014

Somewhat more controversial: These functions never cleanly return so IO () can be IO a.

On first reading, I figured they forked a thread that ran the accept loop based on the IO () return type.

Not clear to me whether this is a breaking API change or whether it's strictly more general. Feel free to reject!

Cheers,

@snoyberg

This comment has been minimized.

Copy link
Member

commented Dec 11, 2014

I need to think about this a bit more. I thought about this change at some point, and I think I came up with a concrete example of breakage from making the change, but I'm not certain.

@snoyberg

This comment has been minimized.

Copy link
Member

commented Dec 15, 2014

I've emailed the cafe about this, let's see if anyone has insight.

@snoyberg snoyberg merged commit e670ef9 into fpco:master Dec 17, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@snoyberg

This comment has been minimized.

Copy link
Member

commented Dec 17, 2014

After the cafe discussion, I've decided to go ahead with this change as a minor version bump (0.1.8). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.