From f0e1a0c5c90641e13911f992f7f8d395ac199a0c Mon Sep 17 00:00:00 2001
From: Fabian Peter Hammerle <fabian@hammerle.me>
Date: Sat, 4 Jun 2022 07:52:55 +0200
Subject: [PATCH] pylint: enable various optional checks/extensions

https://github.com/fphammerle/pubmed-bibtex/commit/30b274aa28d10b4ba69cbf6bcdc42b4198918e19
https://github.com/fphammerle/ical2vdir/commit/3ddcbbd3e757644be6e32cf1c6135c82c845b4ab
---
 .pylintrc                    | 25 +++++++++++++++++++++++--
 freesurfer_stats/__init__.py |  2 +-
 2 files changed, 24 insertions(+), 3 deletions(-)

diff --git a/.pylintrc b/.pylintrc
index ed6a7ed..caf6f79 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -1,3 +1,24 @@
-[MESSAGE CONTROL]
+[MASTER]
 
-disable=missing-docstring
+load-plugins=pylint.extensions.bad_builtin,
+             pylint.extensions.check_elif,
+             pylint.extensions.comparison_placement,
+             pylint.extensions.confusing_elif,
+             pylint.extensions.consider_ternary_expression,
+             pylint.extensions.emptystring,
+             pylint.extensions.eq_without_hash,
+             pylint.extensions.for_any_all,
+             pylint.extensions.mccabe,
+             pylint.extensions.no_self_use,
+             pylint.extensions.overlapping_exceptions,
+             pylint.extensions.private_import,
+             pylint.extensions.redefined_loop_name,
+             pylint.extensions.redefined_variable_type,
+             pylint.extensions.set_membership,
+             pylint.extensions.typing
+
+[MESSAGES CONTROL]
+
+disable=consider-alternative-union-syntax, # requires python>=3.10
+        deprecated-typing-alias, # requires python>=3.9, e.g. for dict[...]
+        missing-docstring
diff --git a/freesurfer_stats/__init__.py b/freesurfer_stats/__init__.py
index 09a5173..fbf1f93 100644
--- a/freesurfer_stats/__init__.py
+++ b/freesurfer_stats/__init__.py
@@ -129,7 +129,7 @@ def _read_headers(self, stream: typing.TextIO) -> None:
             if line:
                 attr_name, attr_value_str = line.split(" ", maxsplit=1)
                 attr_value_str = attr_value_str.lstrip()
-                if attr_name in ["cvs_version", "mrisurf.c-cvs_version"]:
+                if attr_name in {"cvs_version", "mrisurf.c-cvs_version"}:
                     attr_value = typing.cast(
                         typing.Union[str, datetime.datetime],
                         attr_value_str.strip("$").rstrip(),