Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSLoggerViewer: prevent new connections from creating multiple windows #286

Merged
merged 1 commit into from
May 4, 2020
Merged

NSLoggerViewer: prevent new connections from creating multiple windows #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Desktop/Classes/LoggerTransport.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ - (void)attachConnectionToWindow:(LoggerConnection *)aConnection
// make a new document for a connection (it is considered live once we have received
// the ClientInfo message) or reuse an existing document if this is a reconnection
dispatch_async(dispatch_get_main_queue(), ^{
// Wait to receive a ClientInfo with all metadata before attempting to attach
if (aConnection.clientOSName == nil) return;

if (!aConnection.attachedToWindow)
[(LoggerAppDelegate *)[NSApp delegate] newConnection:aConnection fromTransport:self];
});
Expand Down