New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Wcatch-value and unify way to check if files are read. #360

Merged
merged 3 commits into from Oct 4, 2018

Conversation

Projects
None yet
2 participants
@lgremy
Contributor

lgremy commented Oct 2, 2018

This commit removes the warnings produced by -Wcatch-value, probably enabled by default in gcc-8. This is also the occasion to use a unified version to check if the files are correctly read.

Show outdated Hide outdated tests/test_utils.h
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 2, 2018

Codecov Report

Merging #360 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   72.12%   72.12%           
=======================================
  Files          62       62           
  Lines        5391     5391           
=======================================
  Hits         3888     3888           
  Misses       1503     1503

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2219652...ccf2f60. Read the comment docs.

codecov bot commented Oct 2, 2018

Codecov Report

Merging #360 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   72.12%   72.12%           
=======================================
  Files          62       62           
  Lines        5391     5391           
=======================================
  Hits         3888     3888           
  Misses       1503     1503

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2219652...ccf2f60. Read the comment docs.

@malb

This comment has been minimized.

Show comment
Hide comment
@malb

malb Oct 3, 2018

Collaborator

Why the name read_file_process?

Collaborator

malb commented Oct 3, 2018

Why the name read_file_process?

@lgremy

This comment has been minimized.

Show comment
Hide comment
@lgremy

lgremy Oct 3, 2018

Contributor

It is because the function reads the file and uses the operator >> to interpret the content of the file. The name read_file is maybe sufficient.

Contributor

lgremy commented Oct 3, 2018

It is because the function reads the file and uses the operator >> to interpret the content of the file. The name read_file is maybe sufficient.

@malb

This comment has been minimized.

Show comment
Hide comment
@malb

malb Oct 4, 2018

Collaborator

read_file_process sounds like we're reading a file's process somehow. I think either read_file_and_process or read_file would work, where my preference is on the latter.

Collaborator

malb commented Oct 4, 2018

read_file_process sounds like we're reading a file's process somehow. I think either read_file_and_process or read_file would work, where my preference is on the latter.

@malb malb merged commit 5419de4 into fplll:master Oct 4, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 2219652...ccf2f60
Details
codecov/project 72.12% remains the same compared to 2219652
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lgremy lgremy deleted the lgremy:Wcatch-value branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment