Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added solution for potential Win10 issue #370

Merged
merged 1 commit into from May 25, 2019

Conversation

Projects
None yet
2 participants
@tmmlaarhoven
Copy link
Contributor

commented May 25, 2019

When trying to install fplll again in Windows 10, I had the minor issue mentioned above, and found a simple fix online -- it might be useful for others too if they encounter the same issue.

Added solution for potential Win10 issue
When trying to install fplll again in Windows 10, I had the minor issue mentioned above, and found a simple fix online -- it might be useful for others too if they encounter the same issue.

@malb malb merged commit 14ed902 into fplll:master May 25, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@malb

This comment has been minimized.

Copy link
Collaborator

commented May 25, 2019

Ta!

@codecov

This comment has been minimized.

Copy link

commented May 25, 2019

Codecov Report

Merging #370 into master will decrease coverage by 1.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
- Coverage   72.59%   70.83%   -1.77%     
==========================================
  Files          66       63       -3     
  Lines        6109     5136     -973     
==========================================
- Hits         4435     3638     -797     
+ Misses       1674     1498     -176
Impacted Files Coverage Δ
fplll/pruner/pruner.h 58% <0%> (-15%) ⬇️
fplll/nr/matrix.cpp 66.34% <0%> (-6.59%) ⬇️
fplll/nr/nr_FP_ld.inl 79.24% <0%> (-5.67%) ⬇️
fplll/nr/matrix.h 67.39% <0%> (-4.54%) ⬇️
fplll/householder.h 64.4% <0%> (-4.24%) ⬇️
fplll/nr/nr_FP_d.inl 94.44% <0%> (-3.71%) ⬇️
fplll/nr/numvect.h 78.64% <0%> (-3.51%) ⬇️
fplll/nr/nr_FP_qd.inl 69.13% <0%> (-2.47%) ⬇️
fplll/gso_interface.h 40% <0%> (-2.35%) ⬇️
fplll/nr/nr_Z_mpz.inl 82.85% <0%> (-1.1%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0c79ee...5a94c80. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented May 25, 2019

Codecov Report

Merging #370 into master will decrease coverage by 1.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
- Coverage   72.59%   70.83%   -1.77%     
==========================================
  Files          66       63       -3     
  Lines        6109     5136     -973     
==========================================
- Hits         4435     3638     -797     
+ Misses       1674     1498     -176
Impacted Files Coverage Δ
fplll/pruner/pruner.h 58% <0%> (-15%) ⬇️
fplll/nr/matrix.cpp 66.34% <0%> (-6.59%) ⬇️
fplll/nr/nr_FP_ld.inl 79.24% <0%> (-5.67%) ⬇️
fplll/nr/matrix.h 67.39% <0%> (-4.54%) ⬇️
fplll/householder.h 64.4% <0%> (-4.24%) ⬇️
fplll/nr/nr_FP_d.inl 94.44% <0%> (-3.71%) ⬇️
fplll/nr/numvect.h 78.64% <0%> (-3.51%) ⬇️
fplll/nr/nr_FP_qd.inl 69.13% <0%> (-2.47%) ⬇️
fplll/gso_interface.h 40% <0%> (-2.35%) ⬇️
fplll/nr/nr_Z_mpz.inl 82.85% <0%> (-1.1%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0c79ee...5a94c80. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.