Support configuration of custom systemctl status command#39
Merged
fractaledmind merged 1 commit intoOct 22, 2024
Merged
Conversation
fractaledmind
requested changes
Sep 6, 2024
fractaledmind
left a comment
fractaledmind
left a comment
Owner
There was a problem hiding this comment.
Some changes needed given the evolving direction of the library
Some systems may use systemd to manage litestream but the status command may differ from current implementation in Litestream Ruby. This change allows applications to set the systemctl command to check the status.
rossta
force-pushed
the
feat/custom-systemctl-command
branch
from
50c46c6 to
22f5f7a
Compare
Contributor
Author
|
Sounds good, updated the PR with the requested changes. |
Owner
|
Released in v0.12.0 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use systemd in production with litestream-ruby (on Hatchbox). When I check the status of Litestream in the litestream-ruby web ui, the status reported is "not running".
The reason this is happening is that built-in command for litestream-ruby to check the status of the litestream process returns an error message:
On Hatchbox, I need to use a slightly different command to check the status:
To address this, the approach I had in mind is to make the systemctl status command configurable.