Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

non motion drag handlers are overridden on motion components (even when drag prop is undefined)[BUG] #1248

Closed
el-dav opened this issue Sep 7, 2021 · 0 comments 路 Fixed by #1368
Closed
Labels

Comments

@el-dav
Copy link

@el-dav el-dav commented Sep 7, 2021

1. Read the FAQs 馃憞

Done

2. Describe the bug

drag handlers e.g. onDragStart/onDragEnd are being overridden on a motion component, even when the drag prop is false or undefined.

This is an issue as I'd like to add motion animation e.g. for layout on a component, but I have my own drag functionality which uses these callbacks and do not wish to use motion's drag behaviour

3. IMPORTANT: Provide a CodeSandbox reproduction of the bug

https://codesandbox.io/s/nifty-jennings-y20rj?file=/src/App.js

4. Steps to reproduce

Steps to reproduce the behavior:

In the sandbox example there are two elements where I've set drag behaviour. The first is a motion component and this drag behaviour is being overridden even though I don't set the drag prop.

The second example is the expected behaviour where it is not a motion component.

5. Expected behavior

I would expect my drag callbacks to remain intact on a motion component where I have not set the dragprop to true

6. Video or screenshots

7. Environment details

If applicable, let us know which OS, browser, browser version etc you're using.

Mac, Chrome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant