Layout projection: Relative box resolution & Webpack updates #1060
+892
−1,317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0cbe531:
|
adamseckel
reviewed
Mar 29, 2021
Comment on lines
+891
to
+892
| } else { | ||
| } |
There was a problem hiding this comment.
Can this else be removed?
adamseckel
reviewed
Mar 29, 2021
| * This is currently all relative to the top/left of the parent box, | ||
| * but could be expanded in the future. | ||
| */ | ||
| relativeTarget?: AxisBox2D |
There was a problem hiding this comment.
I'm having a hard time seeing where this gets set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a two-pass layout projection calculation, one to resolve relative projection boxes into viewport boxes, and then a second to calculate projection transforms as normal.
This PR also updates Webpack and related libraries to the latest versions.
Note: We're only adding the mechanism to resolve relative bounding boxes. The next step is to go through and choose in which situations we use relative vs viewport