Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle removal of transformTemplate #1415

Merged
merged 3 commits into from Jan 12, 2022
Merged

Conversation

mattgperry
Copy link
Collaborator

@mattgperry mattgperry commented Jan 11, 2022

No description provided.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 11, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9af1444:

Sandbox Source
Framer Motion: Simple animation Configuration
App Store UI using React and Framer Motion Configuration
Framer Motion: Reorder animation Configuration
Framer Motion: growing item positionTransition issue Configuration
Framer Motion: Image lightbox Configuration

@mattgperry mattgperry changed the title Handle removal or transformTemplate Handle removal of transformTemplate Jan 11, 2022
@mattgperry mattgperry requested a review from hemlok Jan 11, 2022
style={{ x: 10 }}
/>
)
expect(container.firstChild).toHaveStyle("transform: translateY(20px)")
Copy link
Collaborator

@hemlok hemlok Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably being thick, but why doesn't this have transform: translateY(20px) translateX(10px)?

Copy link
Collaborator

@hemlok hemlok Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I am, because the template doesn't pass through the transforms 🤦

hemlok
hemlok approved these changes Jan 11, 2022
@mattgperry mattgperry force-pushed the fix/remove-transformtemplate branch from d80f614 to 9af1444 Compare Jan 12, 2022
@mattgperry mattgperry added the automerge label Jan 12, 2022
@mergetron mergetron bot merged commit cb730bd into main Jan 12, 2022
2 checks passed
@mergetron mergetron bot deleted the fix/remove-transformtemplate branch Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants