Handle missing beans for constructor arguments #42

merged 4 commits into from Apr 6, 2013


None yet

2 participants

marcins commented Apr 6, 2013

Tested working on ACF9, ACF10 and Railo 4. Included test case now fails on Raio 4 without the fix being in place.

Fixes #37

marcins added some commits Apr 6, 2013
@marcins marcins Add test that fails on Railo for #37 3230af3
@marcins marcins Fix for constructor args with missing beans
Return an empty structure when argument does not have a correspodning
bean to ensure that it does not have a value set.
@marcins marcins Add a third test with "bookended" args
Just testing the case where there's a bean, no bean and then bean
again to make sure that the fix hasn't introduced any issues
in that case.
@marcins marcins Remove incorrect comment from latest test 3b3e99f

The tests are good. I'll enhance them with strict mode just to exercise both options. The fix is not correct, however but gives me a good starting point.

@seancorfield seancorfield merged commit fe2a4c7 into framework-one:master Apr 6, 2013
@seancorfield seancorfield added a commit to seancorfield/di1 that referenced this pull request Apr 6, 2013
@seancorfield seancorfield Revert a small part of #42 so missing bean doesn't mess up the accumu…
…lator, to address #37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment