New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderData() reset kills sessions #361

Closed
seancorfield opened this Issue Aug 28, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@seancorfield
Member

seancorfield commented Aug 28, 2015

The change introduced in #342 causes session cookies to be killed. Should this just be removed or made conditional or...?

@seancorfield seancorfield added this to the 3.5 milestone Aug 28, 2015

@seancorfield

This comment has been minimized.

Show comment
Hide comment
@seancorfield

seancorfield Aug 28, 2015

Member

My personal feeling is that this wasn't a common enough bug to really need a fix in the first place so I would lean toward deleting that line -- folks just need to be careful when debugging a REST API!

Thoughts @GiancarloGomez ?

Member

seancorfield commented Aug 28, 2015

My personal feeling is that this wasn't a common enough bug to really need a fix in the first place so I would lean toward deleting that line -- folks just need to be careful when debugging a REST API!

Thoughts @GiancarloGomez ?

@GiancarloGomez

This comment has been minimized.

Show comment
Hide comment
@GiancarloGomez

GiancarloGomez Aug 28, 2015

Contributor

Hey @seancorfield,

I believe I use this in a production scenario and I have not had issues with session cookies. I know before this was available I was doing something very similar with functions that I normally extend fw/1 with (an old kind of base for me). If it is causing an issue though I say remove it but I would like to see an example, it is really just a simple cfcontent reset per say (at least how I understood it).

Contributor

GiancarloGomez commented Aug 28, 2015

Hey @seancorfield,

I believe I use this in a production scenario and I have not had issues with session cookies. I know before this was available I was doing something very similar with functions that I normally extend fw/1 with (an old kind of base for me). If it is causing an issue though I say remove it but I would like to see an example, it is really just a simple cfcontent reset per say (at least how I understood it).

@seancorfield

This comment has been minimized.

Show comment
Hide comment
@seancorfield

seancorfield Aug 28, 2015

Member

Initial testing and responses from folks seem to indicate this does not kill session cookies and it may be something in @davidsf's testing setup. Additional investigation is being done.

Member

seancorfield commented Aug 28, 2015

Initial testing and responses from folks seem to indicate this does not kill session cookies and it may be something in @davidsf's testing setup. Additional investigation is being done.

@seancorfield

This comment has been minimized.

Show comment
Hide comment
@seancorfield

seancorfield Aug 31, 2015

Member

@davidsf confirmed this is an issue with his test setup only. Closing.

Member

seancorfield commented Aug 31, 2015

@davidsf confirmed this is an issue with his test setup only. Closing.

@seancorfield

This comment has been minimized.

Show comment
Hide comment
@seancorfield

seancorfield Sep 2, 2015

Member

It turns out this reset() call has a problem related to headers that I've just run into at work. It removes any headers an application sets, such as cross-origin permissions. Because of that, I'm going to revert this in 3.5 and may even back port this removal to 3.1.

Member

seancorfield commented Sep 2, 2015

It turns out this reset() call has a problem related to headers that I've just run into at work. It removes any headers an application sets, such as cross-origin permissions. Because of that, I'm going to revert this in 3.5 and may even back port this removal to 3.1.

@seancorfield seancorfield reopened this Sep 2, 2015

@GiancarloGomez

This comment has been minimized.

Show comment
Hide comment
@GiancarloGomez

GiancarloGomez Sep 2, 2015

Contributor

Makes sense. Thought it was a good idea. I wonder if it happens with ACF function instead, no reason to keep in but do wonder.

Contributor

GiancarloGomez commented Sep 2, 2015

Makes sense. Thought it was a good idea. I wonder if it happens with ACF function instead, no reason to keep in but do wonder.

seancorfield added a commit that referenced this issue Sep 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment