New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaulted properties should not be injected #400

Closed
seancorfield opened this Issue Nov 20, 2015 · 2 comments

Comments

Projects
None yet
1 participant
@seancorfield
Member

seancorfield commented Nov 20, 2015

Thanks to @mjclemente on the CFML Slack for causing me to observe that a property with a default most likely does not represent a dependency (since dependencies don't have defaults).

Accordingly, I'm going to add omitDefaultedProperties but default it to true in 4.0 (a potentially breaking change). I'm also going to change the default for omitTypedProperties to true for the same reason and for consistency. Also a potentially breaking change (for folks who do not currently use that setting).

@seancorfield seancorfield self-assigned this Nov 20, 2015

@seancorfield seancorfield added this to the 4.0 milestone Nov 20, 2015

seancorfield added a commit that referenced this issue Nov 20, 2015

Fix #400 by checking defaulted properties
Change typed property default to ignore (breaking).
Add defaulted property with default to ignore.
Update tests to verify behavior.
@seancorfield

This comment has been minimized.

Show comment
Hide comment
@seancorfield

seancorfield Nov 20, 2015

Member

Needs documenting with a note that this is a breaking change.

Member

seancorfield commented Nov 20, 2015

Needs documenting with a note that this is a breaking change.

@seancorfield

This comment has been minimized.

Show comment
Hide comment
@seancorfield

seancorfield Nov 20, 2015

Member

Soving the BREAKING aspect by adding a changes document for the 4.0 documentation!

Member

seancorfield commented Nov 20, 2015

Soving the BREAKING aspect by adding a changes document for the 4.0 documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment