Better handling of Clojure controller errors #427

Closed
seancorfield opened this Issue Mar 17, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@seancorfield
Member

seancorfield commented Mar 17, 2016

This falls out of my work on fw1-clj in that the current code can't tell the difference between a Clojure controller that won't require / resolve due to syntax errors vs one that is missing.

@seancorfield seancorfield self-assigned this Mar 17, 2016

@seancorfield seancorfield added this to the 4.0 milestone Mar 17, 2016

@seancorfield seancorfield added bug ready in progress and removed ready labels Mar 17, 2016

seancorfield added a commit that referenced this issue Mar 22, 2016

Allow before()/after() #427
Allow any call with `rc` as an argument. When a call does not resolve,
add a dummy (CFML) method to the controller shim so future calls are not
routed through onMissingMethod().

seancorfield added a commit that referenced this issue Mar 22, 2016

Hoist namespace -> bean logic #427
This allows for both `containsBean()` and `getBean()` overrides to be
removed and the parent DI/1 methods to be relied on. This also ensures
that controller shims are created only once and that, even in the event
of direct calls to `getBean()`, no additional metadata operations are
performed.
@seancorfield

This comment has been minimized.

Show comment
Hide comment
@seancorfield

seancorfield Mar 22, 2016

Member

The error handling was more robust than I realized but while trying to trigger various error conditions, I came across a couple of minor bugs around how Clojure controllers are created and some performance enhancements as well. I also enabled before() / after() methods on Clojure controllers. Now I have to check the documentation to see if I mention those don't work.

Member

seancorfield commented Mar 22, 2016

The error handling was more robust than I realized but while trying to trigger various error conditions, I came across a couple of minor bugs around how Clojure controllers are created and some performance enhancements as well. I also enabled before() / after() methods on Clojure controllers. Now I have to check the documentation to see if I mention those don't work.

@seancorfield

This comment has been minimized.

Show comment
Hide comment
@seancorfield

seancorfield Mar 22, 2016

Member

And the answer is "no" so based on those working with pure CFML FW/1 and pure Clojure FW/1, folks should expect them to work with mixed CFML / Clojure FW/1 and therefore this is just a bug fix and doesn't need documenting beyond that.

Member

seancorfield commented Mar 22, 2016

And the answer is "no" so based on those working with pure CFML FW/1 and pure Clojure FW/1, folks should expect them to work with mixed CFML / Clojure FW/1 and therefore this is just a bug fix and doesn't need documenting beyond that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment