New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid buildUrl() when baseUrl ends with a trailing "/" #452

Closed
Tyf0x opened this Issue Oct 13, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@Tyf0x

Tyf0x commented Oct 13, 2016

My links will include a double "/" in their url if I declare

variables.framework.baseURL = "http://" & cgi.HTTP_HOST & "/myapp/"

I feel like having a base URL ending with a trailing slash shouldn't lead to this issue?

Thoughts?

@seancorfield seancorfield added this to the 4.1 milestone Oct 13, 2016

@seancorfield

This comment has been minimized.

Show comment
Hide comment
@seancorfield

seancorfield Oct 13, 2016

Member

Given that FW/1 goes to the trouble of removing trailing slashes elsewhere so they can be optional, you're right that it probably ought to remove them here as well. Good catch!

Member

seancorfield commented Oct 13, 2016

Given that FW/1 goes to the trouble of removing trailing slashes elsewhere so they can be optional, you're right that it probably ought to remove them here as well. Good catch!

@seancorfield seancorfield added the ready label Oct 13, 2016

seancorfield added a commit that referenced this issue Oct 18, 2016

@seancorfield seancorfield added needsdocumenting and removed ready labels Oct 19, 2016

@tonyjunkes

This comment has been minimized.

Show comment
Hide comment
@tonyjunkes

tonyjunkes Oct 19, 2016

Member

@seancorfield, as far as documenting this goes, would you suggest that there just be a note stating a trailing slash will be removed? Here? -> http://framework-one.github.io/documentation/4.1/reference-manual.html#public-string-function-getbaseurl

Member

tonyjunkes commented Oct 19, 2016

@seancorfield, as far as documenting this goes, would you suggest that there just be a note stating a trailing slash will be removed? Here? -> http://framework-one.github.io/documentation/4.1/reference-manual.html#public-string-function-getbaseurl

@seancorfield

This comment has been minimized.

Show comment
Hide comment
@seancorfield

seancorfield Oct 19, 2016

Member

I think a better place to document it would be around the baseURL framework setting but I haven't decided yet (the "needsdocumenting" label is just a reminder to me to make sure the ticket gets onto the change log and for me to decide what else needs updating).

Member

seancorfield commented Oct 19, 2016

I think a better place to document it would be around the baseURL framework setting but I haven't decided yet (the "needsdocumenting" label is just a reminder to me to make sure the ticket gets onto the change log and for me to decide what else needs updating).

@tonyjunkes

This comment has been minimized.

Show comment
Hide comment
@tonyjunkes

tonyjunkes Oct 19, 2016

Member

Ah. Gotcha.

Member

tonyjunkes commented Oct 19, 2016

Ah. Gotcha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment