New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Travis over to CommandBox / TestBox #465

Closed
seancorfield opened this Issue Jan 17, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@seancorfield
Member

seancorfield commented Jan 17, 2017

@seancorfield seancorfield self-assigned this Jan 17, 2017

@seancorfield seancorfield added the ready label Jan 17, 2017

@tonyjunkes

This comment has been minimized.

Show comment
Hide comment
@tonyjunkes

tonyjunkes Jan 17, 2017

Member

Hey @seancorfield,

I had started working on trying to get this functioning a while back but only got so far. Was focusing on testing locally as some tests were failing for me; and my "TestBox/testing in general" knowledge is rather meh :/

I did get Travis to talk with fw1/commandbox/testbox in my forked repo. If ya wanna take a look at what I started, I pushed my attempted changes here -> https://github.com/cfchef/fw1

If there's anything I can do to help just let me know.

Cheers.

Member

tonyjunkes commented Jan 17, 2017

Hey @seancorfield,

I had started working on trying to get this functioning a while back but only got so far. Was focusing on testing locally as some tests were failing for me; and my "TestBox/testing in general" knowledge is rather meh :/

I did get Travis to talk with fw1/commandbox/testbox in my forked repo. If ya wanna take a look at what I started, I pushed my attempted changes here -> https://github.com/cfchef/fw1

If there's anything I can do to help just let me know.

Cheers.

@seancorfield

This comment has been minimized.

Show comment
Hide comment
@seancorfield

seancorfield Jan 17, 2017

Member

Thanks. Will take a look at both yours and the ColdBox module that jclausen pointed me at and see what I can synthesize from both.

Member

seancorfield commented Jan 17, 2017

Thanks. Will take a look at both yours and the ColdBox module that jclausen pointed me at and see what I can synthesize from both.

@tonyjunkes

This comment has been minimized.

Show comment
Hide comment
@tonyjunkes

tonyjunkes Jan 17, 2017

Member

👍🏻

Member

tonyjunkes commented Jan 17, 2017

👍🏻

@seancorfield seancorfield added this to the 4.1 milestone Feb 7, 2017

@seancorfield seancorfield added in progress and removed ready labels Feb 23, 2017

@seancorfield

This comment has been minimized.

Show comment
Hide comment
@seancorfield

seancorfield Feb 24, 2017

Member

Thank you @cfchef That was pretty much exactly what I needed:

https://travis-ci.org/framework-one/fw1/jobs/204814689

Member

seancorfield commented Feb 24, 2017

Thank you @cfchef That was pretty much exactly what I needed:

https://travis-ci.org/framework-one/fw1/jobs/204814689

@seancorfield

This comment has been minimized.

Show comment
Hide comment
@seancorfield

seancorfield Feb 24, 2017

Member

This was the big commit e35fe69 (I forgot to tag it with the issue number).

Member

seancorfield commented Feb 24, 2017

This was the big commit e35fe69 (I forgot to tag it with the issue number).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment