New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusing ColdBox modules: could FW/1 read/load ModuleConfig.cfc? #486

Closed
seancorfield opened this Issue Aug 22, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@seancorfield
Member

seancorfield commented Aug 22, 2017

This arose out of the discussion around @cfchef integrating @elpete's QB ColdBox module and what FW/1 could do to make that integration easier.

@jmohler1970

This comment has been minimized.

jmohler1970 commented Aug 26, 2017

I like how it is does SQL queries in a more CFML manner.

@mjclemente

This comment has been minimized.

Contributor

mjclemente commented Aug 27, 2017

I'm definitely intrigued at the possibility. The Box team is doing some great stuff, and the number of modules on Forgebox is growing, with an understandable tendency towards the ColdBox ecosystem. It would be awesome to be able to plug more of them into FW/1 apps.

@elpete

This comment has been minimized.

elpete commented Aug 27, 2017

One thing that would be useful for me as a ColdBox module author are patterns I can put in my modules to make them easier to tie in to FW/1, even if it is just a cursory understanding that I can slap in the documentation. Things like how to wire up dependencies in DI/1 or patterns like using a diEngine service instead of wirebox directly (though that may be solved with the WireBox adapter for DI/1).

seancorfield added a commit that referenced this issue Aug 30, 2017

@seancorfield seancorfield added this to the 4.5 milestone Aug 30, 2017

@seancorfield seancorfield self-assigned this Aug 30, 2017

@seancorfield seancorfield modified the milestones: 4.2, 4.5 Sep 6, 2017

@seancorfield seancorfield removed this from the 4.2 milestone Sep 14, 2017

@seancorfield seancorfield removed their assignment Sep 14, 2017

@seancorfield

This comment has been minimized.

Member

seancorfield commented Sep 15, 2017

As explained on the mailing list, this just isn't practical in the general case. I'm probably going to leave the two supporting functions (moduleMappings() and installModules(), and the new nullObject CFC) in the code base but not document them so folks who want to work with ColdBox modules have something to start from. I'll be happy to review PRs that expand this functionality in the future -- if folks with deeper knowledge of ColdBox want to push this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment