New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use encodeForURL instead of urlEncodedFormat #493

Merged
merged 1 commit into from Dec 1, 2017

Conversation

Projects
None yet
2 participants
@aliaspooryorik
Contributor

aliaspooryorik commented Dec 1, 2017

Was just looking at #491 and noticed that FW/1 is using urlEncodedFormat.

Suggest updating this to use encodeForURL instead. This requires ACF10+, but I see that already using encodeForHTML which was added in the same ACF release.

@seancorfield seancorfield merged commit f2a8d6c into framework-one:develop Dec 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@seancorfield

This comment has been minimized.

Member

seancorfield commented Dec 1, 2017

Yup, FW/1 now requires ACF 10+ so this is fine. Good catch! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment