New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] build-ks.js script not windows-compatible #306

Closed
JasonKleban opened this Issue Jan 9, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@JasonKleban

JasonKleban commented Jan 9, 2018

Since path separators are \ on Windows, build-ks.js needs to consider this for windows-compatibility.

...
  rollup({
    input: './kitchen-sink/src/app.js',
    plugins: [
      replace({
        'process.env.NODE_ENV': JSON.stringify(env), // or 'production'
        'process.env.TARGET': JSON.stringify(target),
                                                               // flip separators if present 
                                                               // (that is, on Windows)
                                                               // vvvvvvvvvvvvvvvvvvvv
        'framework7-vue': () => path.resolve(__dirname, f7VuePath).replace(/\\/g, '/'), 
...

@JasonKleban JasonKleban changed the title from build-ks.js script not windows-compatible to [v2] build-ks.js script not windows-compatible Jan 9, 2018

@nolimits4web

This comment has been minimized.

Show comment
Hide comment
@nolimits4web

nolimits4web Jan 9, 2018

Member

Thanks

Member

nolimits4web commented Jan 9, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment