New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some backup tool errors for tar and rsync are not caught and do not abort raspiBackup #18

Closed
framps opened this Issue Oct 24, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@framps
Copy link
Owner

framps commented Oct 24, 2017

rsync: symlink "/media/nas-backup/raspberrypi/raspberrypi-rsync-backup-20171024-135259/usr/bin/mailx" -> "/etc/alternatives/mailx" failed: Operation not supported (95)

Environment: rsync backup on a samba mounted partition

@framps framps added the bug label Oct 24, 2017

@framps framps changed the title Some rsync errors are not catched and do not force abort Some backup tool errors (dd, tar, rsync) are not catched and do not abort raspiBackup Nov 3, 2017

@framps

This comment has been minimized.

Copy link
Owner Author

framps commented Nov 3, 2017

Further analysis showed that the root cause is buggy code added in v0.6.2 which caused some return codes not been caught as an error when a tar or rsync backup is created. That's in particular serious for tar backups because tar reports fatal errors with return code 2 which is ignored by raspiBackup. rsync errors 2,3 and 4 are also not caught but is very unlikely to happen:

Quote man rsync:

2      Protocol incompatibility
3      Errors selecting input/output files, dirs
4      Requested action not supported: an attempt was made  to  manipu‐
         late  64-bit files on a platform that cannot support them; or an
         option was specified that is supported by the client and not  by
         the server.

dd backups are not affected.

@framps framps changed the title Some backup tool errors (dd, tar, rsync) are not catched and do not abort raspiBackup Some backup tool errors (dd, tar, rsync) are not caught and do not abort raspiBackup Nov 3, 2017

@framps framps changed the title Some backup tool errors (dd, tar, rsync) are not caught and do not abort raspiBackup Some backup tool errors for tar and rsync are not caught and do not abort raspiBackup Nov 3, 2017

@framps framps self-assigned this Nov 3, 2017

@framps

This comment has been minimized.

Copy link
Owner Author

framps commented Nov 5, 2017

Fixed in v0.6.3.1

@framps framps closed this Nov 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment