New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to define the sender eMailAddress #36

Closed
framps opened this Issue Feb 13, 2018 · 7 comments

Comments

Projects
None yet
2 participants
@framps
Copy link
Owner

framps commented Feb 13, 2018

Right now the sender eMailAddress is hard coded. Make it configurable.

@framps

This comment has been minimized.

Copy link
Owner Author

framps commented Jun 15, 2018

Config option DEFAULT_SENDER_EMAIL will be used. Default is root@$(hostname)

Right now implemented for ssmtp only.

@framps framps removed the accepted label Jun 21, 2018

@framps

This comment has been minimized.

Copy link
Owner Author

framps commented Jul 1, 2018

There is a beta available which includes a fix for this issue. Feel free to grab the beta and verify the fix.

@DanSman

This comment has been minimized.

Copy link

DanSman commented Jul 2, 2018

Do we have to add "DEFAULT_SENDER_EMAIL" to our config?

email to send completion status

DEFAULT_EMAIL="my@email.address"

mailprogram

DEFAULT_MAIL_PROGRAM="ssmtp"

I'm running your beta but I get the same result like before. So, I have to change your script again at the mom.

Edit:
I had to add "DEFAULT_SENDER_EMAIL" and uncomment # email to send completion status
DEFAULT_EMAIL="my@email.address"

@framps

This comment has been minimized.

Copy link
Owner Author

framps commented Jul 2, 2018

Thank you very much for testing the beta. And yes, you have to define `DEFAULT_SENDER_EMAIL". Unfortunately this definition wasn't retrieved by raspiBackup. I just fixed it 😄 Please give it another try.

@DanSman

This comment has been minimized.

Copy link

DanSman commented Jul 2, 2018

Hey

So, I went back to the stable version raspiBackup.0.6.3.2a and I deleted the beta and updated it again. There is still no change in the config you didn't fixed that, right?

I added "DEFAULT_SENDER_EMAIL" and everything is working fine now. It's changing the default sender email now as well.

PS: The check of missing software is working fine here too. I'm using only rsync so that was fine anyway but I had missing software for don't know might be necessary for tar option or whatever. But it's working ;) So far so good. Thanks

@framps

This comment has been minimized.

Copy link
Owner Author

framps commented Jul 3, 2018

There is still no change in the config you didn't fixed that, right?

Ah ... I think I now get your point. The new config doesn't have the new variable included. That's a valid point. I don't update the config for a beta because then they are visible for people downloading the current non beta version which may cause trouble.I will add then when the beta will be pubished for everybody.

I added "DEFAULT_SENDER_EMAIL" and everything is working fine now. It's changing the default sender email now as well.

Thank you for verifying th issue.

PS: The check of missing software is working fine here too. I'm using only rsync so that was fine anyway but I had missing software for don't know might be necessary for tar option or whatever. But it's working ;) So far so good. Thanks

I thought about this. But then the code will be cluttered with various if/then/else statements. That's why I decided to test for everything which may be used.

@framps

This comment has been minimized.

Copy link
Owner Author

framps commented Jul 30, 2018

@framps framps closed this Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment