Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Locales without downcase #28

Merged
merged 1 commit into from Jun 29, 2012

Conversation

Projects
None yet
2 participants
Contributor

eltercero commented Jun 26, 2012

I removed the call to the downcase function in the creation of routes because there are some locales that use the caps letters. For instance, simplified chinese is "zh-CN". And it's kind of weird having all the rails urls with zh-CN except the translated ones.

The only drawback is that it has to be well written in the YAML, but I think it's the correct way.

Thanks!

Owner

francesc commented Jun 29, 2012

Seems ok to me, I'll try to make a new release with this and #27 later on today or next tuesday. Thanks.

francesc added a commit that referenced this pull request Jun 29, 2012

@francesc francesc merged commit ae79894 into francesc:master Jun 29, 2012

Owner

francesc commented Jun 29, 2012

Just released a new version. Let me know if there's any problem. Also added you to contributors list. Thanks!

Contributor

eltercero commented Jun 30, 2012

Thanks to you, Francesc! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment