Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

api_base_url in spec is ignored #1

Closed
timbunce opened this Issue · 1 comment

3 participants

@timbunce
Collaborator

Net::HTTP::Spore->new_from_spec($filename) dies with "unable to create new Net::HTTP::Spore object: base_url is missing" even though base_url is defined as optional and the file contains an api_base_url.

@gempesaw

A few years late, but this seems like the issue is the key name: base_url is correct, but api_base_url is wrong.

See https://github.com/franckcuny/net-http-spore/blob/387048fac3c2f16232d5bb3b41a949b5a95a5bf5/lib/Net/HTTP/Spore.pm#L89-L90 the exact lines of code that die when base_url is missing.

        $opts->{base_url} ||= $spec->{base_url};
        die "base_url is missing!" if !$opts->{base_url};

This can probably be closed :)

@ashb ashb closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.