* added extradata param on notify exception, useful in some case.

* updated README
francois2metz · Apr 1, 2010 · 3a1ce93 · 3a1ce93
1 parent 02984d0
commit 3a1ce93
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 8 deletions.
diff --git a/README.rst b/README.rst
@@ -16,9 +16,18 @@ Usage
 
 ::
 
-        $e = new Services_ErrorNot('http://example.net/', 'my-api-key');
-        $e->notify('big error');
-        $e->notify('big error', '2010-03-03T00:00:42+01:00');
+        $errornot = new Services_ErrorNot('http://example.net/', 'my-api-key');
+        $errornot->notify('big error');
+        $errornot->notify('big error', '2010-03-03T00:00:42+01:00');
+        try 
+        {
+
+        }
+        catch (MyException $e)
+        {
+           errornot->notifyException($e); // send specific exception
+           errornot->notifyException($e, 'foo'); // send specific exception with extra data
+        }       
 
 ErrorNot can install a custom exception handler:
 
@@ -59,7 +68,7 @@ TESTS
         $> php tests/test_errornot.php 
         test_errornot.php
         OK
-        Test cases run: 2/2, Passes: 8, Failures: 0, Exceptions: 0
+        Test cases run: 2/2, Passes: 16, Failures: 0, Exceptions: 0
 
 
 Author

diff --git a/errornot.php b/errornot.php
@@ -65,15 +65,17 @@ public function setNetworkAdapter(HTTP_Request2_Adapter $http_request2_adapter)
     /**
      * Notify Exception
      * @param Exception $exception
+     * @params mixed $extradata optional extra data
      */
-    public function notifyException(Exception $exception)
+    public function notifyException(Exception $exception, $extradata = null)
     {
+        $data = array('extra' => $extradata);
+        isset($_SESSION) ? $data['session'] = $_SESSION : '';
         $this->notify($exception->getMessage(),
                       null, // auto now
                       $exception->getTrace(),
                       array('params' => array('post' => $_POST, 'get' => $_GET, 'cookies' => $_COOKIE)),
-                      $_SERVER,
-                      isset($_SESSION) ? $_SESSION : '');
+                      $_SERVER, $data);
         if (!is_null($this->previous_exception_handler))
         {
             call_user_func($this->previous_exception_handler, $exception);

diff --git a/tests/test_errornot.php b/tests/test_errornot.php
@@ -59,7 +59,7 @@ public function testPostExtraParams()
                            '&error[data][0]=mydata1&error[data][1]=mydata2', urldecode($mock_network->getRequest()->getBody()));
     }
 
-    public function testNotifyExceptionWithEnvironment()
+    public function testNotifyException()
     {
         list($errornot, $mock_network) = $this->createMockRequest();
         try {
@@ -69,6 +69,18 @@ public function testNotifyExceptionWithEnvironment()
         }
         $this->assertNotNull($mock_network->getRequest());
     }
+
+    public function testNotifyExceptionWithData()
+    {
+        $_SERVER = array();
+        list($errornot, $mock_network) = $this->createMockRequest();
+        try {
+            throw new Exception('message exception');
+        } catch (Exception $e)  {
+            $errornot->notifyException($e, 'foo');
+        }
+        $this->assertPattern('/error\[data\]\[extra\]=foo$/', urldecode($mock_network->getRequest()->getBody()));
+    }
 }
 
 class TestErrorNotExceptionHandler extends UnitTestCase