fix(docsearch): remove data-cy attributes

francoischalifour · Aug 24, 2020 · 6bedbb7 · 6bedbb7
1 parent de0d6d7
commit 6bedbb7
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/cypress/integration/search/actions.spec.js b/cypress/integration/search/actions.spec.js
@@ -117,24 +117,30 @@ context('Recent and Favorites', () => {
   it('Recent search can be deleted', () => {
     cy.get('.DocSearch-Button').click();
     cy.get('#docsearch-item-0')
-      .find('[data-cy=remove-recent]')
+      .find('[title="Remove this search from history"]')
       .trigger('click');
     cy.contains('No recent searches').should('be.visible');
   });
 
   it('Recent search can be favorited', () => {
     cy.get('.DocSearch-Button').click();
-    cy.get('#docsearch-item-0').find('[data-cy=fav-recent]').trigger('click');
+    cy.get('#docsearch-item-0')
+      .find('[title="Save this search"]')
+      .trigger('click');
     cy.contains('Favorites').should('be.visible');
     cy.get('#docsearch-item-0').should('be.visible');
     cy.percySnapshot('favorite');
   });
 
   it('Favorite can be deleted', () => {
     cy.get('.DocSearch-Button').click();
-    cy.get('#docsearch-item-0').find('[data-cy=fav-recent]').trigger('click');
+    cy.get('#docsearch-item-0')
+      .find('[title="Save this search"]')
+      .trigger('click');
     cy.wait(2000);
-    cy.get('#docsearch-item-0').find('[data-cy=remove-fav]').trigger('click');
+    cy.get('#docsearch-item-0')
+      .find('[title="Remove this search from favorites"]')
+      .trigger('click');
     cy.contains('No recent searches').should('be.visible');
   });
 });
diff --git a/cypress/integration/search/screenshots.spec.js b/cypress/integration/search/screenshots.spec.js
@@ -107,7 +107,7 @@ describe('Screenshots', () => {
             cy.wait(1000);
             cy.openModal();
             cy.get('#docsearch-item-0')
-              .find('[data-cy=fav-recent]')
+              .find('[title="Save this search"]')
               .trigger('click');
             cy.wait(1000);
             cy.contains('Favorites').should('be.visible');

diff --git a/packages/docsearch-react/src/StartScreen.tsx b/packages/docsearch-react/src/StartScreen.tsx
@@ -45,7 +45,6 @@ export function StartScreen(props: StartScreenProps) {
           <>
             <div className="DocSearch-Hit-action">
               <button
-                data-cy="fav-recent"
                 className="DocSearch-Hit-action-button"
                 title="Save this search"
                 onClick={(event) => {
@@ -63,7 +62,6 @@ export function StartScreen(props: StartScreenProps) {
             </div>
             <div className="DocSearch-Hit-action">
               <button
-                data-cy="remove-recent"
                 className="DocSearch-Hit-action-button"
                 title="Remove this search from history"
                 onClick={(event) => {
@@ -94,7 +92,6 @@ export function StartScreen(props: StartScreenProps) {
         renderAction={({ item, runDeleteTransition }) => (
           <div className="DocSearch-Hit-action">
             <button
-              data-cy="remove-fav"
               className="DocSearch-Hit-action-button"
               title="Remove this search from favorites"
               onClick={(event) => {