New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce abomonation #195

Merged
merged 4 commits into from Oct 11, 2018

Conversation

Projects
None yet
1 participant
@frankmcsherry
Owner

frankmcsherry commented Oct 11, 2018

This light re-organization removes the requirement that timely dataflow Data implement Abomonation. Instead, this requirement creeps in when you want to use exchange channels, where we invoke the communication crate's requirements. These could plausibly be reduced (or redefined, with flags) to serde or bincode traits. It isn't clear if they support sizing, but presumably at great cost and with much copying they can be made to work.

frankmcsherry added some commits Oct 11, 2018

@frankmcsherry

This comment has been minimized.

Show comment
Hide comment
@frankmcsherry

frankmcsherry Oct 11, 2018

Owner

This has changed from a "light re-organization" to intending to support swapping out abomonation for bincode, using the "timely_communication/bincode" feature flag. It eagerly deserializes on receipt of data, and just pretends to not know about the "binary" variant of the enum that is either serialized or owned data.

Owner

frankmcsherry commented Oct 11, 2018

This has changed from a "light re-organization" to intending to support swapping out abomonation for bincode, using the "timely_communication/bincode" feature flag. It eagerly deserializes on receipt of data, and just pretends to not know about the "binary" variant of the enum that is either serialized or owned data.

@frankmcsherry frankmcsherry merged commit 22fc50c into master Oct 11, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@frankmcsherry frankmcsherry deleted the less_abomonable branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment