New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reachability #200

Merged
merged 5 commits into from Nov 5, 2018

Conversation

Projects
None yet
1 participant
@frankmcsherry
Owner

frankmcsherry commented Nov 4, 2018

This PR introduces a few light changes to reachability that may have horribly broken things.

The intent is mostly a refactoring, which attempts to make the progress logic a bit more clear. It is in preparation for a more extensive reworking in which progress tracking is demoted to a secondary thing that a dataflow scheduler does. As such, we are trying to make it as simple as possible here.

The main change that might be surprising is what I think is a bugfix: scopes previously reported outgoing messages as part of their "internal" capabilities, in addition to reporting them as outgoing messages. The capabilities were not released until the next time the scope was interacted with. This may have led to one-round latencies on progress information flowing out of scopes. But it is fixed now, and may or may not be problematic.

@frankmcsherry frankmcsherry merged commit 299af55 into master Nov 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@frankmcsherry frankmcsherry deleted the reachability branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment