Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

v1.3.14 - client sends all cookies on one line

rfe6265 says that a client must send all cookies on one line.  We've been
sending them on multiple lines for a long time and servers haven't
complained but now and this is starting to be a problem, likely due
to rfc6265 stating the one line requirement.

Are there user visible changes in this commit?  yes/no

Is bootstrapping needed?   no

Are tests included for new features?  no new features

Tests run:  t-aserve

Change-Id: Ibf135b107bce5223ed4586fe2c34857c1b2cb99d
  • Loading branch information...
commit 54adb6eb82b0dd72d8bf87cb2bbe64dbaec46c2b 1 parent d22b3df
John Foderaro authored
Showing with 4 additions and 14 deletions.
  1. +3 −13 client.cl
  2. +1 −1  main.cl
View
16 client.cl
@@ -1554,19 +1554,9 @@ or \"foo.com:8000\", not ~s" proxy))
-(defparameter cookie-separator
- ;; useful for separating cookies, one per line
- (make-array 10 :element-type 'character
- :initial-contents '(#\return
- #\linefeed
- #\C
- #\o
- #\o
- #\k
- #\i
- #\e
- #\:
- #\space)))
+; rfc6265 says that all cookies are one line separated by this:
+(defparameter cookie-separator "; ")
+
(defmethod compute-cookie-string (uri (jar cookie-jar))
;; compute a string of the applicable cookies.
View
2  main.cl
@@ -38,7 +38,7 @@
#+ignore
(check-smp-consistency)
-(defparameter *aserve-version* '(1 3 13))
+(defparameter *aserve-version* '(1 3 14))
(eval-when (eval load)
(require :sock)
Please sign in to comment.
Something went wrong with that request. Please try again.