Permalink
Commits on Apr 5, 2018
  1. Bump version to 6.4.beta.0

    dklayer committed Apr 5, 2018
    Change-Id: Idbe78ed27bc98175f4f5bf5c90890a825314febc
    Reviewed-on: https://gerrit.franz.com:9080/10462
  2. Makefile: update comment

    dklayer committed Apr 5, 2018
    for deleting a tag.
    
    Change-Id: If1c2bac7ba292513bcef1d98e09e8a662f7a1d39
    Reviewed-on: https://gerrit.franz.com:9080/10461
Commits on Dec 6, 2017
  1. README.md: add date for 6.3.3

    dklayer committed Dec 5, 2017
    Change-Id: Id69c004db799bad51777a093b62ca00cf093ebbc
    Reviewed-on: https://gerrit.franz.com:9080/9285
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
Commits on Aug 14, 2017
  1. Add STRESS_ITERATIONS variable to Makefile

    dklayer committed Aug 14, 2017
    So the Makefile doesn't need to be edited to change the length of the
    test.
    
    Change-Id: I2e43786f35cc54bd17c657e97d039e7fdfd80c0f
    Reviewed-on: https://gerrit.franz.com:9080/8217
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
  2. bug24843: nfsd crash when unrecognized volume guid seen in

    Ahmon Dancy authored and dklayer committed Aug 14, 2017
     file handle
    
    fhandle.cl:
      recover-persistent-fh
        Handle *enoent* error by returning a stale file handle indicator.
    
    Bumped version to 6.3.3 and updated README.md.
    
    Change-Id: Ia62ff2e8cd359687cac2a3511da9a8d0bbda6764
    Reviewed-on: https://gerrit.franz.com:9080/8214
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
  3. Added test for bug24843

    dancysoft authored and dklayer committed Aug 14, 2017
    Added test-nfs-low test program.  It currently just tests for bug24843
    but I expect to expand the test cases over time.
    
    Makefile:
      Added a test-nfs-low invocation to the 'runtests' target.
    
    test/nfs-common.c:
     Added copy_file_handle function.
    
     Added setup_client function.
    
    test/test-big-readdir-udp.c:
     Use the setup_client function.
    
    Change-Id: Iaf29ae2ed63c468e71269fea53b2c7b70adbab58
    Reviewed-on: https://gerrit.franz.com:9080/8213
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
Commits on Aug 9, 2017
  1. Documentation and 6.3.2 test results

    dklayer committed Aug 8, 2017
    Also, updated README.md with dates for releases.
    
    Change-Id: I2acd800eb621ed01aa8aeff01816058950c4dcf4
    Reviewed-on: https://gerrit.franz.com:9080/8191
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
Commits on Jul 31, 2017
  1. rfe15123: Handle reversed readdir cookie verifier

    Ahmon Dancy authored and dklayer committed Jul 31, 2017
    nfs.cl: add-direntries:
     Updated the cookie verifier check to also allow for a byte-swapped
     verifier.  This is to work around a bug in the Windows 7 NFS client.
    
    utils.cl:
      Added bswap64 function and commented-out test.
    
      Added hex utility function.
    
    README.md: Updated
    
    Change-Id: I4000117cc1331d4d453eda29b2caf5dea6849e5d
    Reviewed-on: https://gerrit.franz.com:9080/8144
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
  2. Misc mods

    Ahmon Dancy authored and dklayer committed Jul 31, 2017
    fhandle.cl:
    
    In the fhandle struct, renamed the alternate-pathnames slot to
    alternate-names to better reflect what it holds (basename strings, not
    pathnames).  Updated affected code.
    
    Updated docstring to make-fhandle.
    
    Updated file handle testing function.
    
    ipaddr.cl:
    
    Commented out a test function.
    
    nfs.cl
    
    Added comments.
    
    Change-Id: I9ebb58502771c30989947b71d6d2c3922429c91b
    Reviewed-on: https://gerrit.franz.com:9080/8143
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
Commits on Jul 26, 2017
  1. rfe15117: Limit readdir results to max UDP packet size

    Ahmon Dancy authored and dklayer committed Jul 26, 2017
    nfs-common.cl:
      Bumped version to 6.3.2.
    
      Added *max-udp-datagram-size* constant.
    
    nfs.cl:
      add-direntries:
        Use the smaller of the caller's requested max return size and
        the max reply size that we can fit into a 64K UDP datagram.
    
    sunrpc.cl:
      Added and exported get-successful-reply-overhead.
    
    test/hammernfs.c:
      Factored out some stuff into nfs-common.[ch]
    
    test/nfs-common.[ch]:
      New, to make it easier to make other test programs which make
      direct NFS RPC calls.
    
    test/test-big-readdir-udp.c:
      An attempt at testing rfe15117.  The program is sufficient for
      demonstrating a too-large-packet situation but it doesn't work well
      once rfe15117 is fixed.
    
    Makefile:
      Added test/nfs-common.c to the dependencies list.
      Added test-big-readdir-udp$(exe) target.
    
    .gitignore:
      Added /test-big-readdir-udp
    
    README.md:
      Added 6.3.2 entry.
    
    Change-Id: Ic6771328fdc772aa8f3659ca77205ee8414d4af6
    Reviewed-on: https://gerrit.franz.com:9080/8119
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
  2. Remove DOS line endings from fhandle.cl/utils.cl

    Ahmon Dancy authored and dklayer committed Jul 26, 2017
    Change-Id: I7a87e30c1c6f7e1ee2c141640578b6016b879a7c
    Reviewed-on: https://gerrit.franz.com:9080/8118
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
Commits on Jul 19, 2017
  1. Simplify testing

    dklayer committed Jul 19, 2017
    New make rule: runtests.  All parameters are in the Makefile just
    before the rule is defined.
    
    Change-Id: I01ae0caf5156b83c7623bcc63a399e35e1781012
    Reviewed-on: https://gerrit.franz.com:9080/8064
    Tested-by: Kevin Layer <layer@franz.com>
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
  2. Update README.md for 6.3.1

    dklayer committed Jul 19, 2017
    Change-Id: I3c17f23f9531796f9beca182bb22c166901c9a79
  3. Fixed symlink-p operation on ACL 10.1

    Ahmon Dancy authored and dklayer committed Jul 19, 2017
    ACL 10.1 is built with Visual Studio 2015.  (ACL 10.0 was built with
    MSVC 6.0).  There are some changes in behavior in the VS 2015 runtime
    libraries (as compared to MSVC 6) which adversely affect the behavior
    of Allegro NFS.  This commit works around those changes.
    
    The notable change in behavior is that the stat64 function now returns
    -1 and ENOENT for pagefile.sys where it didn't before.
    
    This problem is manifested by any operation which uses excl::filestat,
    such as 'file-length' and 'open'.
    
    symlink-p calls file-length on a file to see if it has an even length
    (meaning it might be a symlink file).  symlink-p is used by
    unix-mode-from-file-attributes which is used by unicode-stat and
    stat-via-find-first-file (which is called by unicode-stat).
    
    To work around the problem symlink-p now takes the file-length as a
    required argument.  This information is already available in the
    caller anyway.  symlink-p also now uses with-unicode-open instead of
    with-open-file
    
    Additional code cleanup:
    
    * Factored out a common pattern into dword-pair-to-integer.
    
    * Remove unused old-unicode-stat function.  Removed unused stat64
      struct, wstat64 foreign call, and related foreign type defs.
    
    * Remove unused unix-mode-from-file-information function.
    
    Change-Id: If3a66ba666c44763cde6e1d4f5ba038c1fe4cf9a
    Reviewed-on: https://gerrit.franz.com:9080/8059
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
  4. Include :disasm in the modules list

    Ahmon Dancy authored and dklayer committed Jul 19, 2017
    To help with some backtraces.
    
    Change-Id: I690bbd651984b5992477d34a69640e3d5d16a5dc
    Reviewed-on: https://gerrit.franz.com:9080/8058
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
Commits on Jul 13, 2017
  1. Testing related changes for 6.3

    dklayer committed Jul 10, 2017
    Many misc changes, all related to testing.
    
    doc/testing.txt: updates to the `Performance' section.
    
    results/: output from test/performance.sh goes here, one file per
    version.
    
    Makefile: added rule "results", which products tables of comparisons
    between versions represented by files in that directory.
    
    test/results.cl (renamed from test/performance.cl): revamped arg
    processing.
    
    test/performance.log.*: removed, since they were obsolete
    
    test/performance.sh: modernized, no longer runs on Windows, because
    hammernfs.exe is unreliable in Cygwin.
    
    Change-Id: I845e313eef20d13342934837ab18f2cb48bc3046
    Reviewed-on: https://gerrit.franz.com:9080/8007
    Tested-by: Kevin Layer <layer@franz.com>
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
Commits on Jul 7, 2017
  1. Disable debugging MessageBox's

    dklayer committed Jul 7, 2017
    Change-Id: Ib86920e73caab27903ae804187fd4d4617bcbd3d
    Reviewed-on: https://gerrit.franz.com:9080/7970
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
  2. rfe15068: refine reboot test

    dklayer committed Jul 6, 2017
    Turns out, it is common to have PendingFileRenameOperations.  So, we
    look for "nfs" and "allegro" (case insensitively) in the list of filenames,
    and only force the clearing of them before installation if there is a match.
    
    Change-Id: Idd2e1cd6e16c41c70560e801bfaecd830c9086f5
    Reviewed-on: https://gerrit.franz.com:9080/7967
    Tested-by: Kevin Layer <layer@franz.com>
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
Commits on Jul 6, 2017
  1. Release Notes for 6.3

    dklayer committed Jul 6, 2017
    Change-Id: I67780a62c98ca54c95bc47fade8451d308809590
    Reviewed-on: https://gerrit.franz.com:9080/7965
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
  2. rfe15068: tell user when reboot is needed

    dklayer committed Jun 28, 2017
    and refuse to install if "file renames on reboot" are pending.
    
    Bump version to 6.3.0.  This will be release candidate 1.
    
    Also, remove a statement in the uninstall script that caused the
    reboot flag to be always set when nfs.cfg was preserved.  Basically,
    we were doing
    
      RMDir /rebootok "$INSTDIR"
    
    when nfs.cfg was preserved, and this caused the above to fail, which
    set the reboot flag (because /rebootok was given).  Now, when nfs.cfg
    is preserved, we don't execute the above statement.
    
    Make sure all MessageBox's before aborts consistently use MB_ICONSTOP.
    
    Use a single case for "RMDir".
    
    Also, tested and built with NSIS 3.01, which is now installed on thunder.
    
    Change-Id: I4d250de2c5800b0214689ba093b38a9745c2cc5c
    Reviewed-on: https://gerrit.franz.com:9080/7936
    Tested-by: Kevin Layer <layer@franz.com>
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
Commits on Jun 19, 2017
  1. Comment updates

    unknown authored and dklayer committed Jun 15, 2017
    That is all.
    
    Change-Id: Ifda7e6383eec7cc825e1e76b7ea1c8823a46e5bd
    Reviewed-on: https://gerrit.franz.com:9080/7881
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
  2. rfe15049: Add error message, product version, and timestamp to nfs-er…

    unknown authored and dklayer committed Jun 15, 2017
    …rlog.txt entries
    
    Factored out nfs-errlog.txt backtrace code into a function named
    log-backtrace-to-nfs-errlog.  This function will prefix the backtrace
    with the timestamp (as returned by excl.osi:ctime), product version
    (*nfsd-version*) and git hash (*nfsd-commit-id*) to aid in problem
    investigations.
    
    Change-Id: I87737933b1abc2a19c39bbf754f1407e7991d900
    Reviewed-on: https://gerrit.franz.com:9080/7880
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
Commits on May 31, 2017
  1. rfe14956: Make Allegro NFS resilient to nsm-state file corruption

    dancysoft authored and dklayer committed May 31, 2017
    This is a followup commit for rfe14956 which fixes bogus args in the
    call to my-rename.  Tested manually.
    
    Change-Id: Ibb9b4021df2b14830de8162c352a96c08638d0c2
    Reviewed-on: https://gerrit.franz.com:9080/7801
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
  2. rfe14956: update release notes

    dklayer committed May 31, 2017
    Change-Id: If18a928bdca1f31bc7e55ef29152c656fd74e610
    Reviewed-on: https://gerrit.franz.com:9080/7800
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
  3. Updated the text for export naming

    Ahmon Dancy authored and dklayer committed May 31, 2017
    Change-Id: I6058ee8de8ccaa05c11123e9a4e66e38a700af39
    Reviewed-on: https://gerrit.franz.com:9080/7799
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
Commits on May 30, 2017
  1. rfe14956: Make Allegro NFS resilient to nsm-state file corruption

    Ahmon Dancy authored and dklayer committed Apr 13, 2017
    Bumped version to 6.3.beta.2.
    
    For whatever reason, every once in a while a user reports a problem
    restarting Allegro NFS due to a correct nsm-state file (often filled
    with nulls).  It's unclear why this happens but I did find one
    candidate: The fsync call in nsm-state-save was not preceded by a
    finish-output, so it's possible that nothing was being fsync'd.  I
    took care of that.  I also updated the state file reading code to bail
    out and revert to default initial state if there's a problem reading
    the file.  The broken file will be renamed to nsm-state.broken for
    examination.
    
    Other changes:
    
    Updated my-rename to convert pathnames to namestrings as needed.
    
    hexdump-file function added to utils.cl.
    
    Change-Id: I63ecfa6e2d72cb3bff3baf61754fb4870cd51015
    Reviewed-on: https://gerrit.franz.com:9080/7622
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
Commits on Mar 23, 2017
  1. Update performance data for 6.3.beta.1

    dklayer committed Mar 17, 2017
    Change-Id: Ib1cb9cda36cbe4faa8bd0a4363cdcca458be290d
    Reviewed-on: https://gerrit.franz.com:9080/7507
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
Commits on Mar 20, 2017
  1. Bump version to 6.3.beta.1

    dklayer committed Mar 17, 2017
    Change-Id: Ia93451ecc0c337ab238e86687628a9be01f1ee89
    Reviewed-on: https://gerrit.franz.com:9080/7467
    Tested-by: Kevin Layer <layer@franz.com>
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
  2. rfe14889: sign the installer; use ACL 10.1

    dklayer committed Mar 17, 2017
    Sign the installer, to make people less paranoid.
    
    Use ACL 10.1 for the build.  Also, do not set the aclmalloc heap start.
    Use the default for 10.1, since the heap locations are different (and
    hopefully better).
    
    Change-Id: Ide101616be1a2a59004993d9c431bc5aa13849b9
    Reviewed-on: https://gerrit.franz.com:9080/7466
    Tested-by: Kevin Layer <layer@franz.com>
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
  3. rfe14540: config option for 32-bit file-ids

    dklayer committed Mar 18, 2017
    There is a new configure option for truncating file-ids to 32
    bits, for buggy clients that had problems with 64-bit file-ids
    (even though it is part of the NFS protocol).
    
    Change-Id: Ic9c4c0c79d74a5f40f2066fd069f9b21d78bd93f
    Reviewed-on: https://gerrit.franz.com:9080/7461
    Tested-by: Kevin Layer <layer@franz.com>
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
Commits on Mar 15, 2017
  1. Performance work

    dklayer committed Mar 13, 2017
    Add performance data for 6.2 (baseline) and 6.3.beta.0.
    
    Minor tweaks to performance.cl and performance.sh.
    
    Change-Id: I44372f8b6950b8f5508ebd7fd9ad1cbf9272b14c
    Reviewed-on: https://gerrit.franz.com:9080/7433
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
Commits on Mar 13, 2017
  1. Print debug info when clnt_create fails

    Ahmon Dancy authored and dklayer committed Mar 11, 2017
    Change-Id: I246baafe2795ee736f2cfdf787b1aa0ada48172f
    Reviewed-on: https://gerrit.franz.com:9080/7425
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
Commits on Mar 9, 2017
  1. Bump version to 6.3.beta.0

    dklayer committed Mar 8, 2017
    Misc fixes, cleanups and test helper.
    
    Change-Id: I186e7f6ef268993dcf62fb0dc569b543be0163b0
    Reviewed-on: https://gerrit.franz.com:9080/7396
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
  2. Add program to generate files

    dklayer committed Mar 8, 2017
    Given a count, generate that many files in the current directory.
    
    Change-Id: I66f1077973ba4a18b084a169274a3444afa559bb
    Reviewed-on: https://gerrit.franz.com:9080/7388
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Reviewed-by: Kevin Layer <layer@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>
  3. Refactored subprocess startup code

    Ahmon Dancy authored and dklayer committed Mar 8, 2017
    Change-Id: I05e6f0d33fefa1f89edb4e379ae4342c2a275b7c
    Reviewed-on: https://gerrit.franz.com:9080/7392
    Reviewed-by: Kevin Layer <layer@franz.com>
    Reviewed-by: Ahmon Dancy <dancy@franz.com>
    Tested-by: Kevin Layer <layer@franz.com>