Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix display of seconds between 0 and 9. #1

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
2 participants
@gbm001
Copy link

gbm001 commented Jan 21, 2019

Currently the datepicker display seconds using a single digit when seconds are between 0 and 9 when adding to fields. This commit fixes this for the 'ss' format (the original behaviour is retained for a 's' format).
I might have made a hash of building the minified versions.

@gbm001

This comment has been minimized.

Copy link
Author

gbm001 commented Jan 21, 2019

and then hopefully this fix can make it into Frappe.

@gbm001 gbm001 referenced this pull request Jan 24, 2019

Closed

feat: time format #6659

@gbm001

This comment has been minimized.

Copy link
Author

gbm001 commented Feb 6, 2019

I wouldn't normally do this, but @netchampfaris I think this is your repository (and I guess you don't look at it often, since this is the first pull request)? Any chance of getting this merged in and then updating the minified file in Frappe?

@gbm001

This comment has been minimized.

Copy link
Author

gbm001 commented Feb 26, 2019

Bumpity bump bump...

@gbm001 gbm001 referenced this pull request Feb 28, 2019

Closed

Bug with Datetime field #3550

@gbm001

This comment has been minimized.

Copy link
Author

gbm001 commented Mar 5, 2019

bumpity bumpity bump

@gbm001

This comment has been minimized.

Copy link
Author

gbm001 commented Mar 14, 2019

it's lonely here...

@netchampfaris netchampfaris merged commit ed37b94 into frappe:master Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.