Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added issue templates to help with workflows #807

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Added issue templates to help with workflows #807

merged 3 commits into from
Jan 17, 2024

Conversation

Isaac-GC
Copy link
Collaborator

@Isaac-GC Isaac-GC commented Jan 16, 2024

Added issue templates to help creation of issues and aid in automated workflows in project tab

@Isaac-GC
Copy link
Collaborator Author

@18alantom and @mildred Just tagging you in this PR to see if there other templates you'd like to see or if there are other items in the templates themselves you think we should have.

Thanks :)

@18alantom
Copy link
Member

The templates look good, should raise the bar for reported issues! I think these three should be fine for now.

A minor worry is fewer issues would be raised due to the required steps (albeit they'd be more meaningful).

Also, clicking on Report Issue in Books redirects to the new issue page with a Template: https://github.com/frappe/books/blob/master/src/errorHandling.ts#L195 This might need updating.

description: General Question(s) (for Bugs and Feature Requests, please use the appropriate template)
placeholder: '...'
validations:
required: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could make use of the discussions GitHub feature for this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figure instead of completely pushing people to github discussions or telegram, we would instead continue giving the ability for questions and then sometime in the future, just get rid of it all together (trying to prevent too much change at once)

.github/ISSUE_TEMPLATE/2-feature_template.yml Show resolved Hide resolved
@Isaac-GC
Copy link
Collaborator Author

The templates look good, should raise the bar for reported issues! I think these three should be fine for now.

A minor worry is fewer issues would be raised due to the required steps (albeit they'd be more meaningful).

Also, clicking on Report Issue in Books redirects to the new issue page with a Template: https://github.com/frappe/books/blob/master/src/errorHandling.ts#L195 This might need updating.

Looks like I'll have to update the errorHandling.ts file separately. I can't update it until we have the issue template published due to the urll being different.

@Isaac-GC Isaac-GC merged commit 546b085 into frappe:master Jan 17, 2024
4 checks passed
@Isaac-GC Isaac-GC deleted the issue_templates branch January 17, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants