Fix piechart large arc #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piechart could not render large arcs (>180) properly because the information of large arc was not provided to the SVG drawing function. This was fixed, and the piechart should render correctly when one slice is larger than 180 degrees.
…echart_large_arc
scmmishra
approved these changes
May 22, 2019
This was referenced Jul 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation About What Code Achieves:
ORIGINAL PR: Fix for issues #108 and #117 #152, all I did was merge in master
FIXES: Pie chart display issue. #108
Screenshots/GIFs:
Steps To Test:
TODOs: