Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to manage Default Company Accounts per Branch instead of by Company [Proposal] #17273

Open
tristanvigar opened this issue Apr 17, 2019 · 2 comments

Comments

@tristanvigar
Copy link

commented Apr 17, 2019

Relating to the following links:

https://discuss.erpnext.com/t/how-to-handle-accounts-in-erpnext-for-a-company-with-multiple-branches/4983/18
and
#12596

Our Use Case: We have multiple branches that utilize the same Chart of Accounts. This gives us two options: Use the Company Default Accounts for the largest branch and the others have to change defaults (Could lead to document mistakes) or remove Company Default Accounts (Mistakes are less frequent but this increases the workload and is still likely error prone).

I've been considering implementing a mechanism where I can add a default list of accounts per branch instead of a single Company wide set of defaults. According to the links above, there seems to be interest in this approach but it looks like those were filtered out of the final PR linked to Issue #12596 since they were deemed "unfeasible"

My proposal would be to add a Company checkbox "Default Accounts Managed Per Branch" that would be referenced any time there is a call to retrieve any of these values:

default_bank_account
default_cash_account
default_receivable_account
round_off_account
round_off_cost_center
write_off_account
discount_allowed_account
discount_received_account
exchange_gain_loss_account
unrealized_exchange_gain_loss_account
default_payable_account
default_employee_advance_account
default_expense_account
default_income_account
default_deferred_revenue_account
default_deferred_income_account
default_payroll_payable_account
default_expense_claim_payable_account

default_cost_center

default_inventory_account
stock_adjustment_account
stock_received_but_not_billed
expenses_included_in_valudation

accumulated_depreciation_account
depreciation_expense_account
expenses_included_in_asset_valuation
disposal_account
depreciation_cost_center
capital_work_in_progress_account
asset_received_but_not_billed

If this box is checked in the Company master, the value would be pulled from a separate Default Accounts Per Branch Doctype/Singles table entry based on the active user's branch in their Employee record. This comes with the caveat that if you assist somebody from another branch, you will need to remove the Default accounts and set them back to the accounts for that branch.

Using a checkbox to determine if this functionality should be used makes it easy to disable and by default, would not affect the base installation. It would need to be manually added.

Is this feasible to implement/is there a more concise way to implement this or are there factors that I haven't considered that make this impossible to implement?

@tristanvigar

This comment has been minimized.

Copy link
Author

commented Apr 18, 2019

@rmehta Could you recommend a colleague who would know more about what I'm proposing so I can get more feedback before implementing something like this?

@rmehta

This comment has been minimized.

Copy link
Member

commented Apr 20, 2019

@tristanvigar this best way to implement this is allowing posting against multiple dimensions on the GL against having larger and larger Charts. If you are interested, you can work on the multiple dimension approach. See #17026

cc @nabinhait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.