Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: bulk-format python code with black and enforce in pre-commit #29762

Closed
ankush opened this issue Feb 11, 2022 · 0 comments · Fixed by #29783
Closed

proposal: bulk-format python code with black and enforce in pre-commit #29762

ankush opened this issue Feb 11, 2022 · 0 comments · Fixed by #29783
Labels
discussion meta meta discussions

Comments

@ankush
Copy link
Member

ankush commented Feb 11, 2022

Pros:

  1. Consistent, no-nonsense formatting. No need to ever think about it EVER again.
  2. No need to wait for sider to check and re-push minor formatting fixes ever. (just like how flake8 now forces checks locally before pushing)

Cons:

  1. Github GUI still doesn't support .git-blame-ignore but it will soon.
  2. Short term pains (current open PRs will get buncha conflicts)

(leave 👍 or 👎 to vote and if you've serious objection please explain)
@netchampfaris netchampfaris changed the title propsal: bulk-format python code with black and enforce in pre-commit proposal: bulk-format python code with black and enforce in pre-commit Feb 13, 2022
@ankush ankush mentioned this issue Feb 14, 2022
Merged
4 tasks
@surajshetty3416 surajshetty3416 mentioned this issue Mar 30, 2022
Merged
@frappe frappe locked as resolved and limited conversation to collaborators Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
discussion meta meta discussions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style: force auto-formatted code ankush/erpnext
1 participant
@ankush