Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment terms #10427

Merged
merged 141 commits into from Nov 21, 2017

Conversation

Projects
None yet
@tundebabzy
Copy link
Collaborator

commented Aug 16, 2017

Todo:

  • Payment Term
    • Add validations
      • Test cases Quotes
      • Test cases Sales Order
      • Test cases Sales Invoice
      • Test cases Purchase Order
      • Test cases Purchase Invoice
      • Test Supplier
      • Test Customer
  • Payment Terms Template
  • Payment Terms Template Detail
  • Payment Schedule
    • On selection of Payment Terms Template link, fetch all the terms
    • calculate due dates
    • calculate payment amount
    • on submission, make GLE based on due dates
    • add due_date field in GLE
    • If there is one due date, set it in parent and copy it to the child table
    • If parent due_date is not present, set last due_date as parent due_date
    • Add payment schedule in Quote/SO/SI/PI/PO

Payment Entry

  • Fetch outstanding invoices as per due_date in a separate row
  • Add due_date in reference table
  • post due_date in GLE

Journal Entry

  • Make payment entry via Journal Entry, multiple rows based on due dates
  • Add due_date field in child table
  • Post due_date to GLE
  • Check Payment Entry against Sales/Purchase Order

AR/AP report

  • Show ageing based on multiple due dates

Patch

  • Create Payment Term and Payment Terms Template based on existing Customer/Supplier Credit Days

  • Set default Payment Terms Template in customer/supplier

  • Set Payment Schedule table based on parent due_date

  • Set due_date in existing GLE

  • Set due_date in Journal Entry child table

  • Documentation

@tundebabzy tundebabzy requested a review from nabinhait Aug 16, 2017

@tundebabzy tundebabzy force-pushed the tundebabzy:payment-terms branch from d8a1489 to c4521e2 Aug 19, 2017

nabinhait and others added some commits Aug 15, 2017

Payment Terms: doctypes, schedule, payments and more
fix payment terms template setup:
- add_fetch to correct credit_days and credit_months not credit_days_months

fixed bug in `make_customer_gl_entry` and `make_supplier_entry:
all sales invoice were failing because they were all attempting to
make gl entry from payment schedule. Same with purchase invoices

@tundebabzy tundebabzy force-pushed the tundebabzy:payment-terms branch from c0746cb to d207f92 Aug 20, 2017

tundebabzy added some commits Aug 18, 2017

tests and test fixes
fixes test case:
make sales invoice using customer that does not have credit_days_based_on 'Last Day Of Next Month'
so that it doesn't conflict with payment term due date

fix test case:
create purchase invoice with new supplier with credit_days_based_on
"Fixed Days" as the default "Last Day of Month" does not apply when
using payment terms

@tundebabzy tundebabzy force-pushed the tundebabzy:payment-terms branch from d207f92 to fb14430 Aug 20, 2017

@tundebabzy tundebabzy force-pushed the tundebabzy:payment-terms branch from 0855005 to 6b2d9e4 Aug 25, 2017

@joolsr

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2017

@tundebabzy I really need your new Payment Terms which looks great by the way. Any idea roughly when thsi will be completed and into Master ? Otherwise I may have to add back in my custom payment fields for the time being

@tundebabzy

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 29, 2017

@joolsr Targeted ETA is before September 1

@joolsr

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2017

@tundebabzy That's great ! Is that for completion into Develop rather than Master? Sounds like it should be fine for me anyway . Great news

@tundebabzy

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 29, 2017

@joolsr that will be completion into develop.

tundebabzy added some commits Aug 29, 2017

enhance reference_due_date behaviour:
- creates new api - get_invoice_due_dates
- when reference_name is changed, populate reference_due_date

@tundebabzy tundebabzy force-pushed the tundebabzy:payment-terms branch from 30fa654 to 6575a61 Oct 27, 2017

@giuseppelamatrice

This comment has been minimized.

Copy link

commented Oct 30, 2017

@tundebabzy Where is the problem on this pull? Can I help you?

@tundebabzy

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 30, 2017

Honestly, I have no idea. Test cases are passing locally but failing on Travis.
79f9a4a is the commit that completes the job and the last one that passed on Travis.

@giuseppelamatrice

This comment has been minimized.

Copy link

commented Oct 30, 2017

Can we discuss on Skype? my address is giuseppe.lamatrice@hotmail.it

@knckrz

This comment has been minimized.

Copy link

commented Nov 4, 2017

@tundebabzy Great stuff! Looking forward for this feature. Can't proceed with Erpnext without this. Any idea when will this be available?

@knckrz

This comment has been minimized.

Copy link

commented Nov 14, 2017

Guys, any love for this? For all the effort exerted, this might get buried :(

@tundebabzy

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 14, 2017

No it won't. It'll get merged :)

tundebabzy and others added some commits Nov 14, 2017

@nabinhait nabinhait merged commit 7fa111d into frappe:develop Nov 21, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
codacy/pr Good work! A positive pull request.
Details
security/snyk No new issues
Details
@cosimot

This comment has been minimized.

Copy link

commented Nov 21, 2017

YEEEEEEEE

@knckrz

This comment has been minimized.

Copy link

commented Nov 22, 2017

Is this really it guys??

@FredericLeuba

This comment has been minimized.

Copy link

commented Nov 26, 2017

Hello,
I update bench to develop branch but cannot find anything about these changes.
Can you tell me how to use this new stuff to having several invoices for one SO?
regards
Frédéric

@tundebabzy

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 27, 2017

Thanks for using ERPNext @FredericLeuba. It has not yet been released. It will in a couple of days

@giuseppelamatrice

This comment has been minimized.

Copy link

commented Jan 16, 2018

@tundebabzy MULTIPLE DUE DATE based on payment terms template are calculated on sales invoice OR saved in database table?

@ahmad18189

This comment has been minimized.

Copy link
Contributor

commented Apr 28, 2018

Any Updates?

@knckrz

This comment has been minimized.

Copy link

commented May 14, 2018

@tundebabzy @giuseppelamatrice I installed ERPNEXT v10.1.31, it has payment terms but it only creates one (1) invoice using a payment term with multiple due dates. Did I miss anything? I couldn't figure how the multiple due dates are used in the payment cycle. Are we still having multiple invoices generated from one sales invoice based on multiple due dates on payment terms?

@rebin2002

This comment has been minimized.

Copy link

commented Nov 2, 2018

@nabinhait @tundebabzy @giuseppelamatrice
Any update for these payment terms? also my case is explained in #15831

@sanath2018

This comment has been minimized.

Copy link

commented Dec 14, 2018

Can we see multiple due dates on AR AP reports now?

@giuseppelamatrice

This comment has been minimized.

Copy link

commented Dec 14, 2018

I don't have any idea. Is under develop version

@sanath2020

This comment has been minimized.

Copy link

commented Feb 6, 2019

Any one have a clue that multiple due dates are working in version 11??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.