Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Invoice/Delivery note customer po_no overwritten by Sales order #15785

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
3 participants
@patilsangram
Copy link
Contributor

commented Oct 24, 2018

Validation Issue: In Sales Invoice/Delivery Note, customer po_no is overwritten by Null po_no from Sales Order

Issue ref: #14812

Sangram Patil
Indictranstech Technologies Pvt. Ltd, Pune

@patilsangram patilsangram changed the title Po no fix [fix] Invoice/Delivery note customer po_no overwritten by Sales order Oct 24, 2018

@Zlash65

This comment has been minimized.

Copy link
Member

commented Oct 24, 2018

Hey, can you checkout to staging-fixes and do a git pull. Then run git branch -D po_no_fix. Then run git checkout -b po_no_fix. Next, run git cherry-pick 92dcc25. Finally, do git push <your remote name> po_no_fix -f

@patilsangram patilsangram force-pushed the patilsangram:po_no_fix branch from 92dcc25 to 6472c90 Oct 24, 2018

@patilsangram

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2018

Thanks, @Zlash65. Done

@codingCoffee codingCoffee force-pushed the frappe:staging-fixes branch from c17a647 to 9750d5c Oct 25, 2018

@stale

This comment has been minimized.

Copy link

commented Nov 4, 2018

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Nov 4, 2018

@rmehta rmehta merged commit 667f0fb into frappe:staging-fixes Nov 8, 2018

2 of 4 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
coverage/coveralls Coverage decreased (-0.0008%) to 51.341%
Details
Travis CI - Pull Request Build Passed
Details
security/snyk - requirements.txt (frappe) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.