Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Payment entry not able to submit in multi-currency #15859

Merged

Conversation

Projects
None yet
2 participants
@rohitwaghchaure
Copy link
Contributor

commented Oct 30, 2018

Steps to replicate the issue

  • Created sales invoice in USD(base currency is INR) and submitted it
  • Clicked on make payment > selected Accounts Paid To in USD Account and Paid From in INR
  • Clicked on button Set Exchange Gain/Loss button
  • Saved payment entry and while submission getting below error
    screen shot 2018-10-30 at 12 37 10 pm

After debug come to know that
Payment entry not able to submit because of precision issues
Here value of difference amount is showing as 0 in the form and on the console showing as -0.000276

@rohitwaghchaure rohitwaghchaure changed the title [Fix] Payment entry not able to submit [Fix] Payment entry not able to submit in multi-currency Oct 30, 2018

@nabinhait nabinhait self-assigned this Nov 2, 2018

@nabinhait nabinhait merged commit dcb71a6 into frappe:hotfix Nov 2, 2018

1 of 3 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
Travis CI - Pull Request Build Failed
Details
security/snyk - requirements.txt (frappe) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.