Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set operations for Work Order when created from Material Request #16154

Merged
merged 1 commit into from Dec 24, 2018

Conversation

Projects
None yet
2 participants
@Alchez
Copy link
Contributor

commented Dec 4, 2018

Describe the bug
When you create a Work Order from a Material Request, the BOM operations for that item do not get copied over, which doesn't activate Job Cards and breaks the manufacturing workflow.

To Reproduce
Steps to reproduce the behavior:

  1. Create, save and submit a Material Request set to "Manufacture" for any item that has a BOM with operations.
  2. Click on "Make" on the top-right section.
  3. Click on "Work Order" from the dropdown menu.
  4. The newly created Work Order will not have any operations.

Expected behavior
Create Work Orders from Material Request for items that need operations.

Desktop (please complete the following information):

  • OS: Ubuntu 18.04
  • Browser: Chrome
  • Version: 70
@Alchez

This comment has been minimized.

Copy link
Contributor Author

commented Dec 11, 2018

I'm trying to run tests for Material Request, but it keeps failing at trying to fetch BOMs, saying they don't exist.

There is a line in there:

test_dependencies = ["Currency Exchange", "BOM"],

which I thought would create it. Do I need to setup these fixtures separately?

@rmehta rmehta merged commit 349040d into frappe:staging-fixes Dec 24, 2018

2 of 3 checks passed

Travis CI - Pull Request Build Failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
security/snyk - requirements.txt (frappe) No manifest changes detected
@rmehta

This comment has been minimized.

Copy link
Member

commented Dec 24, 2018

Merging for now, but next time #NoTestNoMerge

@Alchez Alchez deleted the Alchez:hotfix-work-order-ops branch Dec 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.