Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tax Category and Item Tax Template (v12) #16377

Merged
merged 30 commits into from Feb 2, 2019

Conversation

Projects
None yet
4 participants
@SaiFi0102
Copy link
Collaborator

commented Jan 9, 2019

Requires the PR in frappe: frappe/frappe#6772

Moved Item Tax Rates from Item Master to Item Tax Template Master:

image


You can create Tax Category to apply different taxes based on the Tax Category:

image


Item Taxes are set like this:

image

An empty Tax Category means that this Item Tax will be applied when the Tax Category in transactions is also empty

You can also set Item Tax Templates on Item Group:

image

Item Tax Templates applied on an Item Group will be effective on all its descendants too unless a descendant Item Group overrides it OR an Item overrides it

You can select Tax Category from any transaction which will set Item Tax Templates automatically:

image


You can also manually select Item Tax Template for each Item in a transaction:

image


You can also assign a Tax Category to a Customer, Supplier or a specific Address so that the Tax Category is automatically selected:

image

image


You can even create a Tax Rule with a Tax Category filter so that Taxes and Charges Template is automatically selected:

image


You can configure these new features:

image

SaiFi0102 and others added some commits Nov 24, 2018

Saif Ur Rehman
Merge branch 'staging' of https://github.com/frappe/erpnext.git into …
…Item-Tax-Template

# Conflicts:
#	erpnext/selling/doctype/quotation_item/quotation_item.json
#	erpnext/stock/doctype/item/item.json
Saif Ur Rehman
Saif Ur Rehman
Merge branch 'staging-fixes' of https://github.com/frappe/erpnext.git
…into Item-Tax-Template

# Conflicts:
#	erpnext/accounts/doctype/accounts_settings/accounts_settings.json
#	erpnext/accounts/doctype/purchase_invoice/purchase_invoice.json
#	erpnext/accounts/doctype/purchase_invoice_item/purchase_invoice_item.json
#	erpnext/accounts/doctype/sales_invoice/sales_invoice.json
#	erpnext/accounts/doctype/sales_invoice_item/sales_invoice_item.json
#	erpnext/buying/doctype/purchase_order/purchase_order.json
#	erpnext/buying/doctype/purchase_order_item/purchase_order_item.json
#	erpnext/buying/doctype/supplier/supplier.json
#	erpnext/buying/doctype/supplier_quotation/supplier_quotation.json
#	erpnext/buying/doctype/supplier_quotation_item/supplier_quotation_item.json
#	erpnext/selling/doctype/quotation/quotation.json
#	erpnext/selling/doctype/quotation_item/quotation_item.json
#	erpnext/selling/doctype/sales_order/sales_order.json
#	erpnext/selling/doctype/sales_order_item/sales_order_item.json
#	erpnext/setup/doctype/item_group/item_group.json
#	erpnext/stock/doctype/delivery_note/delivery_note.json
#	erpnext/stock/doctype/delivery_note_item/delivery_note_item.json
#	erpnext/stock/doctype/item/item.json
#	erpnext/stock/doctype/purchase_receipt_item/purchase_receipt_item.json
Merge branch 'staging-fixes' of https://github.com/frappe/erpnext.git
…into Item-Tax-Template

# Conflicts:
#	erpnext/patches.txt
Merge branch 'Item-Tax-Template' of https://github.com/SaiFi0102/erpn…
…ext.git into Item-Tax-Template-V12

# Conflicts:
#	erpnext/patches.txt
#	erpnext/stock/doctype/item/item.json

@SaiFi0102 SaiFi0102 requested a review from nabinhait Jan 24, 2019

@nabinhait
Copy link
Member

left a comment

@SaiFi0102 I have tested manually, it is working quite well. A few observation:

  • "Automatically Add Taxes and Charges from Item Tax Template" checkbox should be checked by default and it should be default behaviour.
  • Item Tax Template should be shown in default grid view (with item_code, qty, rate and amount) in transactions.
Merge branch 'develop' of https://github.com/frappe/erpnext.git into …
…Item-Tax-Template-V12

# Conflicts:
#	erpnext/patches.txt

@nabinhait nabinhait merged commit 690b830 into frappe:develop Feb 2, 2019

2 of 4 checks passed

Travis CI - Pull Request Build Errored
Details
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
Semantic Pull Request ready to be squashed
Details
security/snyk - requirements.txt (frappe) No manifest changes detected

@SaiFi0102 SaiFi0102 deleted the SaiFi0102:Item-Tax-Template-V12 branch Feb 2, 2019

@SaiFi0102 SaiFi0102 referenced this pull request Mar 23, 2019

Closed

[Proposal] Item Tax Template #14187

7 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.