Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(projects): Auto-set employee and company in Timesheet #16743

Merged
merged 5 commits into from Mar 26, 2019

Conversation

Projects
None yet
4 participants
@barredterra
Copy link
Contributor

commented Feb 21, 2019

Use-case

User creates a new Timesheet.

Old behavior

At the moment, when creating a Timesheet, the user has to enter his name and company manually.

New behavior

If there is an Employee with matching user_id for the session user, set employee and company automatically.

If another person creates the Timesheet, she would have to click on the employee field and set the specific employee manually. Setting the employee will only be necessary in this special case.

screencast

Also added semicolons, where missing.

@barredterra

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

Thanks for the hint, done. @nabinhait

@barredterra

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2019

Anything else I can do to get this merged, @nabinhait?

@barredterra

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

@sagarvora did anything happen to Nabin?

@sagarvora sagarvora requested a review from nabinhait Mar 25, 2019

@sagarvora sagarvora merged commit fdbb516 into frappe:hotfix Mar 26, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Semantic Pull Request ready to be squashed
Details
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage remained the same at 51.847%
Details
security/snyk - requirements.txt (frappe) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.