Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Status updater for Credit/Debit Note Issued #16998

Merged

Conversation

Projects
None yet
3 participants
@SaiFi0102
Copy link
Collaborator

commented Mar 24, 2019

When a standalone Credit/Debit note is made, the status instead of showing "Credit Note Issued" shows "Return".

So I changed the status updater logic so that
"Credit/Debit Note Issued" is shown when there is a negative Outstanding Balance
"Return" is shown when Outstanding Balance is 0 and "Is Return" is set

SaiFi0102 added some commits Apr 22, 2019

Merge branch 'master' of https://github.com/frappe/erpnext.git into F…
…ix-Credit-Debit-Note-Status-Updater
Merge branch 'hotfix' of https://github.com/frappe/erpnext.git into F…
…ix-Credit-Debit-Note-Status-Updater

@stale stale bot added the inactive label May 22, 2019

@frappe frappe deleted a comment from stale bot May 23, 2019

@stale stale bot removed the inactive label May 23, 2019

@nabinhait nabinhait merged commit 05f2998 into frappe:hotfix May 27, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Semantic Pull Request ready to be squashed
Details
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 52.061%
Details
security/snyk - requirements.txt (frappe) No manifest changes detected

@SaiFi0102 SaiFi0102 deleted the SaiFi0102:Fix-Credit-Debit-Note-Status-Updater branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.