Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make Quotation from Lead with no company #17732

Closed
wants to merge 13 commits into from

Conversation

@Don-Leopardo
Copy link
Contributor

Don-Leopardo commented May 23, 2019

fix #17723
It was caused because there wasn't a company configured in the Global Defaults of the instance. Anyways, the error message wasn't clear and I think that if the company is required to make a Quotation from the Lead it should be required to create a Lead in the first place.
I added the required to company in Lead and bow the error message is going to be clear because it's going to say that the company field is required for Lead.

Copy link
Member

saurabh6790 left a comment

@Don-Leopardo Transactions are specific to companies but master data can be shared across multiple companies. Thus the field is not mandatory by default.

If the error message is not clear on the transaction, then we have to fix the error message by adding a more descriptive message.

@saurabh6790

This comment has been minimized.

Copy link
Member

saurabh6790 commented May 24, 2019

@nabinhait Please check this

@Don-Leopardo

This comment has been minimized.

Copy link
Contributor Author

Don-Leopardo commented May 28, 2019

@saurabh6790 The company is assigned to the lead automatically and in a field that is almost hidden. There is no difference in making it required, it only saves the case when you forget to configure the company in global configuration, that is this case.

Don-Leopardo and others added 12 commits May 28, 2019
@nabinhait

This comment has been minimized.

Copy link
Member

nabinhait commented Jul 12, 2019

Fixed the issue #17723 via #18292, closing this PR.

@nabinhait nabinhait closed this Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.