Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: General Ledger Group by Voucher not ordering by posting_date #17845

Merged
merged 9 commits into from Jul 14, 2019

Conversation

@Don-Leopardo
Copy link
Contributor

Don-Leopardo commented Jun 4, 2019

fix #17707

Don-Leopardo and others added 4 commits Jun 5, 2019
Copy link
Member

rmehta left a comment

Please also raise corresponding PR for develop branch

@Don-Leopardo

This comment has been minimized.

Copy link
Contributor Author

Don-Leopardo commented Jun 21, 2019

@rmehta PR for develop: #18023

@rohitwaghchaure

This comment has been minimized.

Copy link
Contributor

rohitwaghchaure commented Jun 25, 2019

@Don-Leopardo I have checked in my local account and found that both frappe._dict() and OrderedDict() giving the same result. Can you add the screenshot of general ledger report before and after fix.

@Don-Leopardo

This comment has been minimized.

Copy link
Contributor Author

Don-Leopardo commented Jun 25, 2019

@rohitwaghchaure sure. You are not seeing the difference probably because you don't have different types of documents with different dates. Here are the screenshots:

Before

sincambios

After

concambios

@rohitwaghchaure rohitwaghchaure merged commit 6b86bb4 into frappe:hotfix Jul 14, 2019
5 checks passed
5 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Semantic Pull Request ready to be squashed
Details
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage remained the same at 52.168%
Details
security/snyk - requirements.txt (frappe) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.