fix: Version 12 Bank Reconciliation fix #19182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 12
Change fixes Bank Rec upload as well as the duplicatation of bank_account and company filters
Mitchy25
changed the title
Removing incorrect fix to filters. Filters are loaded from Bank Transaction List.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
|
Wondering why this pull request is not being merged ?? |
nabinhait
approved these changes
Nov 6, 2019
|
This issue seems to have resurfaced again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue in Version-12 where the Bank Reconciliation is unable to upload a csv/xlsx file.
Bank Rec was using frappe.upload.make. This pull req upgrades to the current file upload procedure (frappe.ui.FileUploader).
This pull req also fixes the duplication of the bank_account and company filters.