Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [WIP] Whatsapp integration #19251

Open
wants to merge 22 commits into
base: develop
from

Conversation

@fproldan
Copy link
Contributor

fproldan commented Oct 4, 2019

Whatsapp integration

Issue: #19196
Feedback is appreciated

Whatsapp Settings

Doctype to configure Twilio account

Captura de Pantalla 2019-10-04 a la(s) 14 17 03

SMS Center

  • New field message type.
    Captura de Pantalla 2019-10-04 a la(s) 14 18 33

Send SMS

  • New field message type (default SMS).
  • Attach document Print (only visible if message type is Whatsapp)
    Captura de Pantalla 2019-10-04 a la(s) 14 18 54

TODO

  • Define a new name for SMS Center (for example Message Center), and apply the required modifications.

  • Define a new name the Send SMS action (for example Send Message).

  • Test definitions

@mhbu50

This comment has been minimized.

Copy link
Contributor

mhbu50 commented Oct 5, 2019

@fproldan Grate job!
I think this PR should be in frappe
It will be more useful for custome app which will not use Erpnext

@fproldan fproldan changed the title Whatsapp integration feat: [WIP] Whatsapp integration Oct 5, 2019
fproldan added 3 commits Oct 7, 2019
@fproldan

This comment has been minimized.

Copy link
Contributor Author

fproldan commented Oct 17, 2019

We are planning to create a new notification channel to send notifications via WhatsApp. The idea is to move the WhatsApp settings (like they are in this pr) to Frappe and let the changes in SMS Center and Send Message button in ERPNext (using the Frappe's WhatsApp settings).
But, before we start to do it, we want to have some feedback from the Frappe team about what have done and what we are going to do. Maybe from one of you: @rohitwaghchaure @nabinhait @deepeshgarg007
The purpose of the feedback, besides the suggestion of changes and the contribution of new ideas, is to know if this has the possibility to be merged. Like, if you know that this is not going to be merged because of reasons you can tell us so we don't waste effort following the Frappe's coding rules.

fproldan added 2 commits Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.